Issue 852963004: [turbofan] Improve AstGraphBuilder::BuildToBoolean() for heap constants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 852963004: [turbofan] Improve AstGraphBuilder::BuildToBoolean() for heap constants. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer

Modified:
5 years, 11 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

[turbofan] Improve AstGraphBuilder::BuildToBoolean() for heap constants. R=mstarzinger@chromium.org Committed: https://crrev.com/5c43818edec7719c56409b99a2e5c9366d618f08 Cr-Commit-Position: refs/heads/master@{#26082}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	src/compiler/ast-graph-builder.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 7 (1 generated)

Michael Starzinger

LGTM to this change. But looking at Object::BooleanValue I get a little bit scared about ...

5 years, 11 months ago (2015-01-15 15:30:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852963004/1

5 years, 11 months ago (2015-01-15 15:31:36 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-15 17:09:00 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/5c43818edec7719c56409b99a2e5c9366d618f08
Cr-Commit-Position: refs/heads/master@{#26082}