Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 852863003: Revert of [Telemetry] Fix WPR files not being downloaded when required. (Closed)

Created:
5 years, 11 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Fix WPR files not being downloaded when required. (patchset #4 id:60001 of https://codereview.chromium.org/834173006/) Reason for revert: Possible suspect for newly introduced telemetry unit test flake, e.g.: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/1965/steps/telemetry_unittests/logs/stdio Reverting to see what happens. Original issue's description: > [Telemetry] Fix WPR files not being downloaded when required. > > BUG= > > Committed: https://crrev.com/672e7140315568e9bfc442770a23fee66e045cb2 > Cr-Commit-Position: refs/heads/master@{#311496} TBR=nednguyen@google.com,aiolos@chromium.org,lizeb@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/6041d4206970522a18f49afb1ba069651dc22ba2 Cr-Commit-Position: refs/heads/master@{#311551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M tools/telemetry/telemetry/unittest_util/system_stub.py View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/wpr/archive_info.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/wpr/archive_info_unittest.py View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ken Rockot(use gerrit already)
Created Revert of [Telemetry] Fix WPR files not being downloaded when required.
5 years, 11 months ago (2015-01-14 22:07:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852863003/1
5 years, 11 months ago (2015-01-14 22:08:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 22:10:23 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6041d4206970522a18f49afb1ba069651dc22ba2 Cr-Commit-Position: refs/heads/master@{#311551}
5 years, 11 months ago (2015-01-14 22:11:19 UTC) #4
Ken Rockot(use gerrit already)
5 years, 11 months ago (2015-01-15 00:34:48 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/794363005/ by rockot@chromium.org.

The reason for reverting is: Reverting my revert because it didn't fix the
flake! Churn, churn, churn....

Powered by Google App Engine
This is Rietveld 408576698