Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 852803002: Correctly check VPN state in TrayVpn (Closed)

Created:
5 years, 11 months ago by stevenjb
Modified:
5 years, 11 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews, sadrul, stevenjb+watch_chromium.org, oshima+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_onc_crash
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly check VPN state in TrayVpn BUG=448768 Committed: https://crrev.com/dc457c695de374cf5906720d23c658dc4bcfa0f8 Cr-Commit-Position: refs/heads/master@{#311521}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/system/chromeos/network/tray_vpn.cc View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 7 (2 generated)
stevenjb
https://codereview.chromium.org/852803002/diff/1/ash/system/chromeos/network/tray_vpn.cc File ash/system/chromeos/network/tray_vpn.cc (left): https://codereview.chromium.org/852803002/diff/1/ash/system/chromeos/network/tray_vpn.cc#oldcode81 ash/system/chromeos/network/tray_vpn.cc:81: if (!vpn || (vpn->connection_state() == shill::kStateIdle)) { This was ...
5 years, 11 months ago (2015-01-14 17:57:26 UTC) #2
bartfab (slow)
LGTM. Thanks for the quick fix.
5 years, 11 months ago (2015-01-14 17:58:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852803002/1
5 years, 11 months ago (2015-01-14 18:09:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 19:05:47 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 19:07:51 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/dc457c695de374cf5906720d23c658dc4bcfa0f8
Cr-Commit-Position: refs/heads/master@{#311521}

Powered by Google App Engine
This is Rietveld 408576698