Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 852783002: [turbofan] Fix corner case in loop analysis. (Closed)

Created:
5 years, 11 months ago by titzer
Modified:
5 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix corner case in loop analysis. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/3244a66543ef2ab20eb41c1adce1d9d0a5744929 Cr-Commit-Position: refs/heads/master@{#26063}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M src/compiler/loop-analysis.cc View 1 3 chunks +8 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-loop-analysis.cc View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
titzer
5 years, 11 months ago (2015-01-14 16:21:12 UTC) #1
Michael Starzinger
LGTM with one nit. https://codereview.chromium.org/852783002/diff/1/src/compiler/loop-analysis.cc File src/compiler/loop-analysis.cc (right): https://codereview.chromium.org/852783002/diff/1/src/compiler/loop-analysis.cc#newcode191 src/compiler/loop-analysis.cc:191: NodeInfo& CreateLoopInfo(Node* node, NodeInfo& ni) ...
5 years, 11 months ago (2015-01-14 16:28:32 UTC) #2
titzer
On 2015/01/14 16:28:32, Michael Starzinger wrote: > LGTM with one nit. > > https://codereview.chromium.org/852783002/diff/1/src/compiler/loop-analysis.cc > ...
5 years, 11 months ago (2015-01-14 17:06:01 UTC) #3
titzer
Committed patchset #2 (id:20001) manually as 3244a66543ef2ab20eb41c1adce1d9d0a5744929 (presubmit successful).
5 years, 11 months ago (2015-01-14 17:06:44 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 17:06:45 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3244a66543ef2ab20eb41c1adce1d9d0a5744929
Cr-Commit-Position: refs/heads/master@{#26063}

Powered by Google App Engine
This is Rietveld 408576698