Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 852773004: win: Add implementation of ExecutablePath (Closed)

Created:
5 years, 11 months ago by scottmg
Modified:
5 years, 11 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : GetModuleFileName instead #

Patch Set 3 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M util/test/executable_path_test.cc View 1 2 2 chunks +6 lines, -1 line 0 comments Download
A util/test/executable_path_win.cc View 1 1 chunk +29 lines, -0 lines 0 comments Download
M util/util.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
scottmg
5 years, 11 months ago (2015-01-15 04:06:07 UTC) #3
Mark Mentovai
LGTM
5 years, 11 months ago (2015-01-15 17:54:40 UTC) #4
scottmg
5 years, 11 months ago (2015-01-15 18:00:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:80001) manually as
7e7b65da1b0fbb6da20ac1e37a66bd9c8ed4c0e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698