Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 852763002: [turbofan] Use PlainPrimitiveToNumber whenever possible. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
dcarney, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use PlainPrimitiveToNumber whenever possible. TEST=cctest,unittests R=jarin@chromium.org Committed: https://crrev.com/1a5db24e6bf831e61e3f4aa0c252f77e48c3689c Cr-Commit-Position: refs/heads/master@{#26071}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -36 lines) Patch
M src/compiler/js-typed-lowering.cc View 6 chunks +12 lines, -32 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-14 14:10:02 UTC) #1
dcarney
lgtm
5 years, 11 months ago (2015-01-15 09:21:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852763002/1
5 years, 11 months ago (2015-01-15 09:22:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 09:49:19 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a5db24e6bf831e61e3f4aa0c252f77e48c3689c Cr-Commit-Position: refs/heads/master@{#26071}
5 years, 11 months ago (2015-01-15 09:49:32 UTC) #7
Benedikt Meurer
5 years, 11 months ago (2015-01-15 13:26:12 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/852153003/ by bmeurer@chromium.org.

The reason for reverting is: Tanks performance of SQLite and towers.c..

Powered by Google App Engine
This is Rietveld 408576698