Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 852753002: Revert of Update V8 to version 4.2.1 (based on cf09a5a1912e0b1ba3dd92e4e67358618736f6aa). (Closed)

Created:
5 years, 11 months ago by Fabrice (no longer in Chrome)
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 4.2.1 (based on cf09a5a1912e0b1ba3dd92e4e67358618736f6aa). (patchset #1 id:1 of https://codereview.chromium.org/847343002/) Reason for revert: Speculative revert due to build failure on Win8 GN debug builder http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/2984 Original issue's description: > Update V8 to version 4.2.1 (based on cf09a5a1912e0b1ba3dd92e4e67358618736f6aa). > > TBR=machenbach@chromium.org > > Committed: https://crrev.com/63aed1cdc517914528cbbe744b1ae89ba8dbdee6 > Cr-Commit-Position: refs/heads/master@{#311438} TBR=machenbach@chromium.org,v8-autoroll@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b75df192c6ba5394fb4d8edf5a66747e7da51b4f Cr-Commit-Position: refs/heads/master@{#311445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Fabrice (no longer in Chrome)
Created Revert of Update V8 to version 4.2.1 (based on cf09a5a1912e0b1ba3dd92e4e67358618736f6aa).
5 years, 11 months ago (2015-01-14 10:23:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852753002/1
5 years, 11 months ago (2015-01-14 10:24:09 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-14 10:24:11 UTC) #4
pasko-google - do not use
lgtm, thank you
5 years, 11 months ago (2015-01-14 10:26:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852753002/1
5 years, 11 months ago (2015-01-14 10:27:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 10:28:11 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b75df192c6ba5394fb4d8edf5a66747e7da51b4f Cr-Commit-Position: refs/heads/master@{#311445}
5 years, 11 months ago (2015-01-14 10:29:08 UTC) #9
Michael Achenbach
5 years, 11 months ago (2015-01-14 10:36:43 UTC) #10
Message was sent while issue was closed.
Meh - so why is there no trybot/cq coverage for this??

Powered by Google App Engine
This is Rietveld 408576698