Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 852703002: Merge StyleSheetCollection into ScopedStyleResolver. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Merge StyleSheetCollection into ScopedStyleResolver. There's no reason to keep two identical lists of the sheets and have this separate object. I also moved the updating logic out of StyleResolver and into ScopedStyleResolver which makes more sense. There's still some weirdness since some global state still exists in the StyleResolver, but that's something we can fix in future patches. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3c623f54af5118489abbeb7e803c94dec8dddd46

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -225 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.h View 3 chunks +23 lines, -7 lines 0 comments Download
M sky/engine/core/css/resolver/ScopedStyleResolver.cpp View 4 chunks +76 lines, -7 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.h View 1 chunk +4 lines, -1 line 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 2 chunks +10 lines, -27 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 2 chunks +5 lines, -2 lines 0 comments Download
D sky/engine/core/dom/StyleSheetCollection.h View 1 chunk +0 lines, -76 lines 0 comments Download
D sky/engine/core/dom/StyleSheetCollection.cpp View 1 chunk +0 lines, -92 lines 0 comments Download
M sky/engine/core/dom/TreeScope.h View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/TreeScope.cpp View 4 chunks +2 lines, -5 lines 0 comments Download
M sky/engine/core/html/HTMLStyleElement.cpp View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
lgtm
5 years, 11 months ago (2015-01-14 02:30:52 UTC) #1
esprehn
5 years, 11 months ago (2015-01-14 02:37:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3c623f54af5118489abbeb7e803c94dec8dddd46 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698