Issue 8527002: Fix to allow getters and setters (or other elements with the same name) to be uniquely identified...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8527002: Fix to allow getters and setters (or other elements with the same name) to be uniquely identified... (Closed)

Created:
9 years, 1 month ago by Brian Wilkerson

Modified:
9 years, 1 month ago

Reviewers:
messick, keertip

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix to allow getters and setters (or other elements with the same name) to be uniquely identified (fix for http://code.google.com/p/dart/issues/detail?id=397) Committed: https://code.google.com/p/dart/source/detail?r=1413

Created: 9 years, 1 month ago

		Unified diffs	Side-by-side diffs	Stats (+34 lines, -12 lines)
	M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/CompilationUnitImpl.java	View	11 chunks	+18 lines, -10 lines	0 comments
	M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/SourceReferenceImpl.java	View	2 chunks	+16 lines, -2 lines	0 comments

Total messages: 3 (0 generated)

messick

9 years, 1 month ago (2011-11-10 18:11:59 UTC) #3

LGTM
As discussed, you might want to define hashCode() for SourceReferenceImpl.