Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 8527002: Fix to allow getters and setters (or other elements with the same name) to be uniquely identified... (Closed)

Created:
9 years, 1 month ago by Brian Wilkerson
Modified:
9 years, 1 month ago
Reviewers:
messick, keertip
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix to allow getters and setters (or other elements with the same name) to be uniquely identified (fix for http://code.google.com/p/dart/issues/detail?id=397) Committed: https://code.google.com/p/dart/source/detail?r=1413

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/CompilationUnitImpl.java View 11 chunks +18 lines, -10 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/internal/model/SourceReferenceImpl.java View 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Brian Wilkerson
9 years, 1 month ago (2011-11-10 17:58:00 UTC) #1
keertip
lgtm
9 years, 1 month ago (2011-11-10 18:05:26 UTC) #2
messick
9 years, 1 month ago (2011-11-10 18:11:59 UTC) #3
LGTM
As discussed, you might want to define hashCode() for SourceReferenceImpl.

Powered by Google App Engine
This is Rietveld 408576698