Issue 852643002: Always set affected by bits in ElementRuleCollector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 852643002: Always set affected by bits in ElementRuleCollector. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
eseidel, ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Always set affected by bits in ElementRuleCollector. We need to always set these bits, not just if the selector matched otherwise :hover and friends won't ever match. BUG=448465 R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/5ae1fc2790d407366f2954cf6f8ea4fedb1cace9

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -12 lines)			Patch
	M	sky/engine/core/css/ElementRuleCollector.cpp	View		1 chunk	+15 lines, -12 lines	0 comments	Download

Total messages: 5 (2 generated)

esprehn

5 years, 11 months ago (2015-01-13 22:11:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5ae1fc2790d407366f2954cf6f8ea4fedb1cace9 (presubmit successful).