Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Unified Diff: Source/modules/quota/StorageErrorCallback.h

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/quota/StorageErrorCallback.h
diff --git a/Source/modules/quota/StorageErrorCallback.h b/Source/modules/quota/StorageErrorCallback.h
index a7a1d11a8f78c3985d3a73f4ea572d6956ff0cd1..c15a0eab6bae028187b48d382bf3911817a6e16a 100644
--- a/Source/modules/quota/StorageErrorCallback.h
+++ b/Source/modules/quota/StorageErrorCallback.h
@@ -42,14 +42,14 @@ class DOMError;
typedef int ExceptionCode;
-class StorageErrorCallback : public RefCounted<StorageErrorCallback> {
+class StorageErrorCallback {
public:
virtual ~StorageErrorCallback() { }
virtual bool handleEvent(DOMError*) = 0;
class CallbackTask : public ExecutionContextTask {
public:
- static PassOwnPtr<CallbackTask> create(PassRefPtr<StorageErrorCallback> callback, ExceptionCode ec)
+ static PassOwnPtr<CallbackTask> create(PassOwnPtr<StorageErrorCallback> callback, ExceptionCode ec)
{
return adoptPtr(new CallbackTask(callback, ec));
}
@@ -57,9 +57,9 @@ public:
virtual void performTask(ExecutionContext*);
private:
- CallbackTask(PassRefPtr<StorageErrorCallback>, ExceptionCode);
+ CallbackTask(PassOwnPtr<StorageErrorCallback>, ExceptionCode);
- RefPtr<StorageErrorCallback> m_callback;
+ OwnPtr<StorageErrorCallback> m_callback;
ExceptionCode m_ec;
};
};
« no previous file with comments | « Source/modules/notifications/NotificationPermissionCallback.h ('k') | Source/modules/quota/StorageErrorCallback.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698