Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2280)

Unified Diff: Source/modules/mediastream/UserMediaRequest.h

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Patch for landing Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/mediastream/RTCVoidRequestImpl.cpp ('k') | Source/modules/mediastream/UserMediaRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediastream/UserMediaRequest.h
diff --git a/Source/modules/mediastream/UserMediaRequest.h b/Source/modules/mediastream/UserMediaRequest.h
index 3523ae5b4a372e497cddccab43c69c14b34ce779..8ad62dd47441378b368ce41397747fe5050745c0 100644
--- a/Source/modules/mediastream/UserMediaRequest.h
+++ b/Source/modules/mediastream/UserMediaRequest.h
@@ -51,7 +51,7 @@ class UserMediaController;
class UserMediaRequest : public RefCounted<UserMediaRequest>, public ContextLifecycleObserver {
public:
- static PassRefPtr<UserMediaRequest> create(ExecutionContext*, UserMediaController*, const Dictionary& options, PassRefPtr<NavigatorUserMediaSuccessCallback>, PassRefPtr<NavigatorUserMediaErrorCallback>, ExceptionState&);
+ static PassRefPtr<UserMediaRequest> create(ExecutionContext*, UserMediaController*, const Dictionary& options, PassOwnPtr<NavigatorUserMediaSuccessCallback>, PassOwnPtr<NavigatorUserMediaErrorCallback>, ExceptionState&);
~UserMediaRequest();
NavigatorUserMediaSuccessCallback* successCallback() const { return m_successCallback.get(); }
@@ -73,15 +73,15 @@ public:
virtual void contextDestroyed();
private:
- UserMediaRequest(ExecutionContext*, UserMediaController*, PassRefPtr<MediaConstraintsImpl> audio, PassRefPtr<MediaConstraintsImpl> video, PassRefPtr<NavigatorUserMediaSuccessCallback>, PassRefPtr<NavigatorUserMediaErrorCallback>);
+ UserMediaRequest(ExecutionContext*, UserMediaController*, PassRefPtr<MediaConstraintsImpl> audio, PassRefPtr<MediaConstraintsImpl> video, PassOwnPtr<NavigatorUserMediaSuccessCallback>, PassOwnPtr<NavigatorUserMediaErrorCallback>);
RefPtr<MediaConstraintsImpl> m_audio;
RefPtr<MediaConstraintsImpl> m_video;
UserMediaController* m_controller;
- RefPtr<NavigatorUserMediaSuccessCallback> m_successCallback;
- RefPtr<NavigatorUserMediaErrorCallback> m_errorCallback;
+ OwnPtr<NavigatorUserMediaSuccessCallback> m_successCallback;
+ OwnPtr<NavigatorUserMediaErrorCallback> m_errorCallback;
};
} // namespace WebCore
« no previous file with comments | « Source/modules/mediastream/RTCVoidRequestImpl.cpp ('k') | Source/modules/mediastream/UserMediaRequest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698