Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h - Issue 85263006: Make IDL Callbacks non-refcounted by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/mediastream/RTCSessionDescriptionCallback.h ('k') | Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

diff --git a/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h b/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

index f6f0bb7de44cea3dca1c9e6f278ea7fb3e93abb0..3d383ecbf37139f4f3bf327d53bd6129f3dfdc3e 100644

--- a/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

+++ b/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h

@@ -46,7 +46,7 @@ class RTCSessionDescriptionCallback;

class RTCSessionDescriptionRequestImpl : public RTCSessionDescriptionRequest, public ActiveDOMObject {

public:

- static PassRefPtr<RTCSessionDescriptionRequestImpl> create(ExecutionContext*, PassRefPtr<RTCSessionDescriptionCallback>, PassRefPtr<RTCErrorCallback>);

+ static PassRefPtr<RTCSessionDescriptionRequestImpl> create(ExecutionContext*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);

virtual ~RTCSessionDescriptionRequestImpl();

virtual void requestSucceeded(const blink::WebRTCSessionDescription&) OVERRIDE;

@@ -56,12 +56,12 @@ public:

virtual void stop() OVERRIDE;

private:

- RTCSessionDescriptionRequestImpl(ExecutionContext*, PassRefPtr<RTCSessionDescriptionCallback>, PassRefPtr<RTCErrorCallback>);

+ RTCSessionDescriptionRequestImpl(ExecutionContext*, PassOwnPtr<RTCSessionDescriptionCallback>, PassOwnPtr<RTCErrorCallback>);

void clear();

- RefPtr<RTCSessionDescriptionCallback> m_successCallback;

- RefPtr<RTCErrorCallback> m_errorCallback;

+ OwnPtr<RTCSessionDescriptionCallback> m_successCallback;

+ OwnPtr<RTCErrorCallback> m_errorCallback;

};

} // namespace WebCore