Source/web/NotificationPresenterImpl.h - Issue 85263006: Make IDL Callbacks non-refcounted by default

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/NotificationPresenterImpl.h

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Patch for landing Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/modules/webmidi/MIDISuccessCallback.h ('k') | Source/web/NotificationPresenterImpl.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2009 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50	50

51 // WebCore::NotificationPresenter implementation.	51 // WebCore::NotificationPresenter implementation.

52 virtual bool show(WebCore::Notification* object);	52 virtual bool show(WebCore::Notification* object);

53 virtual void cancel(WebCore::Notification* object);	53 virtual void cancel(WebCore::Notification* object);

54 virtual void notificationObjectDestroyed(WebCore::Notification* object);	54 virtual void notificationObjectDestroyed(WebCore::Notification* object);

55 virtual void notificationControllerDestroyed();	55 virtual void notificationControllerDestroyed();

56 virtual WebCore::NotificationClient::Permission checkPermission(WebCore::Exe cutionContext*);	56 virtual WebCore::NotificationClient::Permission checkPermission(WebCore::Exe cutionContext*);

57 #if ENABLE(LEGACY_NOTIFICATIONS)	57 #if ENABLE(LEGACY_NOTIFICATIONS)

58 virtual void requestPermission(WebCore::ExecutionContext*, WTF::PassRefPtr<W ebCore::VoidCallback>);	58 virtual void requestPermission(WebCore::ExecutionContext*, WTF::PassRefPtr<W ebCore::VoidCallback>);

59 #endif	59 #endif

60 virtual void requestPermission(WebCore::ExecutionContext*, WTF::PassRefPtr<W ebCore::NotificationPermissionCallback>);	60 virtual void requestPermission(WebCore::ExecutionContext*, WTF::PassOwnPtr<W ebCore::NotificationPermissionCallback>);

61 virtual void cancelRequestsForPermission(WebCore::ExecutionContext*) { }	61 virtual void cancelRequestsForPermission(WebCore::ExecutionContext*) { }

62	62

63 private:	63 private:

64 // WebNotificationPresenter that this object delegates to.	64 // WebNotificationPresenter that this object delegates to.

65 WebNotificationPresenter* m_presenter;	65 WebNotificationPresenter* m_presenter;

66 };	66 };

67	67

68 } // namespace blink	68 } // namespace blink

69	69

70 #endif // NotificationPresenterImpl_h	70 #endif // NotificationPresenterImpl_h

OLD	NEW