Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: Source/bindings/v8/V8MutationCallback.h

Issue 85263006: Make IDL Callbacks non-refcounted by default (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Refinements Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 13 matching lines...) Expand all
24 */ 24 */
25 25
26 #ifndef V8MutationCallback_h 26 #ifndef V8MutationCallback_h
27 #define V8MutationCallback_h 27 #define V8MutationCallback_h
28 28
29 #include "bindings/v8/ActiveDOMCallback.h" 29 #include "bindings/v8/ActiveDOMCallback.h"
30 #include "bindings/v8/DOMWrapperWorld.h" 30 #include "bindings/v8/DOMWrapperWorld.h"
31 #include "bindings/v8/ScopedPersistent.h" 31 #include "bindings/v8/ScopedPersistent.h"
32 #include "bindings/v8/V8Utilities.h" 32 #include "bindings/v8/V8Utilities.h"
33 #include "core/dom/MutationCallback.h" 33 #include "core/dom/MutationCallback.h"
34 #include "wtf/OwnPtr.h"
35 #include "wtf/RefPtr.h"
34 #include <v8.h> 36 #include <v8.h>
35 #include "wtf/RefPtr.h"
36 37
37 namespace WebCore { 38 namespace WebCore {
38 39
39 class ExecutionContext; 40 class ExecutionContext;
40 41
41 class V8MutationCallback : public MutationCallback, public ActiveDOMCallback { 42 class V8MutationCallback : public MutationCallback, public ActiveDOMCallback {
42 public: 43 public:
43 static PassRefPtr<V8MutationCallback> create(v8::Handle<v8::Function> callba ck, ExecutionContext* context, v8::Handle<v8::Object> owner, v8::Isolate* isolat e) 44 static PassOwnPtr<V8MutationCallback> create(v8::Handle<v8::Function> callba ck, ExecutionContext* context, v8::Handle<v8::Object> owner, v8::Isolate* isolat e)
44 { 45 {
45 ASSERT(context); 46 ASSERT(context);
46 return adoptRef(new V8MutationCallback(callback, context, owner, isolate )); 47 return adoptPtr(new V8MutationCallback(callback, context, owner, isolate ));
47 } 48 }
48 49
49 virtual void call(const Vector<RefPtr<MutationRecord> >&, MutationObserver*) OVERRIDE; 50 virtual void call(const Vector<RefPtr<MutationRecord> >&, MutationObserver*) OVERRIDE;
50 virtual ExecutionContext* executionContext() const OVERRIDE { return Context LifecycleObserver::executionContext(); } 51 virtual ExecutionContext* executionContext() const OVERRIDE { return Context LifecycleObserver::executionContext(); }
51 52
52 private: 53 private:
53 V8MutationCallback(v8::Handle<v8::Function>, ExecutionContext*, v8::Handle<v 8::Object>, v8::Isolate*); 54 V8MutationCallback(v8::Handle<v8::Function>, ExecutionContext*, v8::Handle<v 8::Object>, v8::Isolate*);
54 55
55 static void makeWeakCallback(v8::Isolate*, v8::Persistent<v8::Function>*, V8 MutationCallback*); 56 static void makeWeakCallback(v8::Isolate*, v8::Persistent<v8::Function>*, V8 MutationCallback*);
56 57
57 ScopedPersistent<v8::Function> m_callback; 58 ScopedPersistent<v8::Function> m_callback;
58 RefPtr<DOMWrapperWorld> m_world; 59 RefPtr<DOMWrapperWorld> m_world;
59 v8::Isolate* m_isolate; 60 v8::Isolate* m_isolate;
60 }; 61 };
61 62
62 } 63 }
63 64
64 #endif // V8MutationCallback_h 65 #endif // V8MutationCallback_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698