LayoutTests/fast/events/constructors/track-event-constructor.html - Issue 85263002: Improve handling of dictionary conversions.

Unified Diff: LayoutTests/fast/events/constructors/track-event-constructor.html

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have conversion methods take a context argument; elaborate error msgs further. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: LayoutTests/fast/events/constructors/track-event-constructor.html

diff --git a/LayoutTests/fast/events/constructors/track-event-constructor.html b/LayoutTests/fast/events/constructors/track-event-constructor.html

index f4f50dfbcd3b6c50325768ff101e6eb105d1a503..ca635632bb6ba8ffeec6a7538039f60eda858251 100644

--- a/LayoutTests/fast/events/constructors/track-event-constructor.html

+++ b/LayoutTests/fast/events/constructors/track-event-constructor.html

@@ -27,20 +27,20 @@

shouldBeNull("new TrackEvent('TrackEvent', { bubbles: true, cancelable: true }).track");

debug("<br>*** Bubbles and cancelable true, invalid track ***");

- shouldBe("new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTMLTrackElement }).bubbles", "true");

- shouldBe("new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTMLTrackElement }).cancelable", "true");

- shouldBeNull("new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTMLTrackElement }).track");

+ shouldThrow("new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTMLTrackElement }).bubbles");

+ shouldThrow("new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTMLTrackElement }).cancelable");

+ shouldThrow("new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTMLTrackElement }).track");

debug("<br>*** Initialize 'track' with a invalid values ***");

- shouldBeNull("new TrackEvent('TrackEvent', { track: 10 }).track");

- shouldBeNull("new TrackEvent('TrackEvent', { track: \'string\' }).track");

+ shouldThrow("new TrackEvent('TrackEvent', { track: 10 }).track");

+ shouldThrow("new TrackEvent('TrackEvent', { track: \'string\' }).track");

emptyObject = { };

- shouldBeNull("new TrackEvent('TrackEvent', { track: emptyObject }).track");

- shouldBeNull("new TrackEvent('TrackEvent', { track: document }).track");

+ shouldThrow("new TrackEvent('TrackEvent', { track: emptyObject }).track");

+ shouldThrow("new TrackEvent('TrackEvent', { track: document }).track");

debug("<br>*** Bubbles and cancelable true, valid track ***");

- shouldBe("new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTMLTrackElement }).bubbles", "true");

- shouldBe("new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: HTMLTrackElement }).cancelable", "true");

+ shouldBe("new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: trackElement.track }).bubbles", "true");

+ shouldBe("new TrackEvent('TrackEvent', { bubbles: true, cancelable: true, track: trackElement.track }).cancelable", "true");

shouldBe("new TrackEvent('TrackEvent', { track: trackElement.track }).track", "trackElement.track");

debug("<br>*** Initialize 'track' with valid track object ***");