LayoutTests/fast/events/constructors/keyboard-event-constructor.html - Issue 85263002: Improve handling of dictionary conversions.

Unified Diff: LayoutTests/fast/events/constructors/keyboard-event-constructor.html

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have conversion methods take a context argument; elaborate error msgs further. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/constructors/focus-event-constructor-expected.txt ('k') | LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt » ('j') | Source/bindings/v8/Dictionary.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/events/constructors/keyboard-event-constructor.html

diff --git a/LayoutTests/fast/events/constructors/keyboard-event-constructor.html b/LayoutTests/fast/events/constructors/keyboard-event-constructor.html

index ff7a6ed72445b0dda2ab9da37390db3d5aad6802..0fd8f26c391d0038359ec9bbac459f3878a22ebe 100644

--- a/LayoutTests/fast/events/constructors/keyboard-event-constructor.html

+++ b/LayoutTests/fast/events/constructors/keyboard-event-constructor.html

@@ -37,20 +37,21 @@ shouldBe("new KeyboardEvent('eventType', { view: window }).view", "window");

shouldBe("new KeyboardEvent('eventType', { view: this }).view", "this");

// Non-window objects.

-shouldBe("new KeyboardEvent('eventType', { view: testObject }).view", "null");

-shouldBe("new KeyboardEvent('eventType', { view: document }).view", "null");

+shouldThrow("new KeyboardEvent('eventType', { view: testObject }).view");

+shouldThrow("new KeyboardEvent('eventType', { view: document }).view");

shouldBe("new KeyboardEvent('eventType', { view: undefined }).view", "null");

shouldBe("new KeyboardEvent('eventType', { view: null }).view", "null");

-shouldBe("new KeyboardEvent('eventType', { view: false }).view", "null");

-shouldBe("new KeyboardEvent('eventType', { view: true }).view", "null");

-shouldBe("new KeyboardEvent('eventType', { view: '' }).view", "null");

-shouldBe("new KeyboardEvent('eventType', { view: 'chocolate' }).view", "null");

-shouldBe("new KeyboardEvent('eventType', { view: 12345 }).view", "null");

-shouldBe("new KeyboardEvent('eventType', { view: 18446744073709551615 }).view", "null");

-shouldBe("new KeyboardEvent('eventType', { view: NaN }).view", "null");

+shouldThrow("new KeyboardEvent('eventType', { view: false }).view");

+shouldThrow("new KeyboardEvent('eventType', { view: true }).view");

+shouldThrow("new KeyboardEvent('eventType', { view: '' }).view");

+shouldThrow("new KeyboardEvent('eventType', { view: 'chocolate' }).view");

+shouldThrow("new KeyboardEvent('eventType', { view: 12345 }).view");

+shouldThrow("new KeyboardEvent('eventType', { view: 18446744073709551615 }).view");

+shouldThrow("new KeyboardEvent('eventType', { view: NaN }).view");

// Note that valueOf() is not called, when the left hand side is evaluated.

-shouldBeFalse("new KeyboardEvent('eventType', { view: {valueOf: function () { return window; } } }).view == window");

-shouldBe("new KeyboardEvent('eventType', { get view() { return 123; } }).view", "null");

+shouldThrow("new KeyboardEvent('eventType', { view: {valueOf: function () { return window; } } }).view == window");

+shouldBe("new KeyboardEvent('eventType', { get view() { return window; } }).view", "window");

+shouldThrow("new KeyboardEvent('eventType', { get view() { return 123; } }).view");

shouldThrow("new KeyboardEvent('eventType', { get view() { throw 'KeyboardEvent Error'; } })");

// keyIdentifier is passed.