LayoutTests/fast/events/constructors/composition-event-constructor.html - Issue 85263002: Improve handling of dictionary conversions.

Unified Diff: LayoutTests/fast/events/constructors/composition-event-constructor.html

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have conversion methods take a context argument; elaborate error msgs further. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/fast/events/constructors/composition-event-constructor.html

diff --git a/LayoutTests/fast/events/constructors/composition-event-constructor.html b/LayoutTests/fast/events/constructors/composition-event-constructor.html

index 6869b3e7de5f38ea984e0e1fde2845db1cb6a4d9..cf88295bc47b938d04997dc51db53cce650843c8 100644

--- a/LayoutTests/fast/events/constructors/composition-event-constructor.html

+++ b/LayoutTests/fast/events/constructors/composition-event-constructor.html

@@ -31,20 +31,21 @@ shouldBe("new CompositionEvent('eventType', { view: window }).view", "window");

shouldBe("new CompositionEvent('eventType', { view: this }).view", "this");

// Non-window objects.

-shouldBe("new CompositionEvent('eventType', { view: testObject }).view", "null");

-shouldBe("new CompositionEvent('eventType', { view: document }).view", "null");

+shouldThrow("new CompositionEvent('eventType', { view: testObject }).view");

+shouldThrow("new CompositionEvent('eventType', { view: document }).view");

shouldBe("new CompositionEvent('eventType', { view: undefined }).view", "null");

shouldBe("new CompositionEvent('eventType', { view: null }).view", "null");

-shouldBe("new CompositionEvent('eventType', { view: false }).view", "null");

-shouldBe("new CompositionEvent('eventType', { view: true }).view", "null");

-shouldBe("new CompositionEvent('eventType', { view: '' }).view", "null");

-shouldBe("new CompositionEvent('eventType', { view: 'chocolate' }).view", "null");

-shouldBe("new CompositionEvent('eventType', { view: 12345 }).view", "null");

-shouldBe("new CompositionEvent('eventType', { view: 18446744073709551615 }).view", "null");

-shouldBe("new CompositionEvent('eventType', { view: NaN }).view", "null");

+shouldThrow("new CompositionEvent('eventType', { view: false }).view");

+shouldThrow("new CompositionEvent('eventType', { view: true }).view");

+shouldThrow("new CompositionEvent('eventType', { view: '' }).view");

+shouldThrow("new CompositionEvent('eventType', { view: 'chocolate' }).view");

+shouldThrow("new CompositionEvent('eventType', { view: 12345 }).view");

+shouldThrow("new CompositionEvent('eventType', { view: 18446744073709551615 }).view");

+shouldThrow("new CompositionEvent('eventType', { view: NaN }).view");

// Note that valueOf() is not called, when the left hand side is evaluated.

-shouldBeFalse("new CompositionEvent('eventType', { view: {valueOf: function () { return window; } } }).view == window");

-shouldBe("new CompositionEvent('eventType', { get view() { return 123; } }).view", "null");

+shouldThrow("new CompositionEvent('eventType', { view: {valueOf: function () { return window; } } }).view == window");

+shouldBe("new CompositionEvent('eventType', { get view() { return window; } }).view", "window");

+shouldThrow("new CompositionEvent('eventType', { get view() { return 123; } }).view");

shouldThrow("new CompositionEvent('eventType', { get view() { throw 'CompositionEvent Error'; } })");

// data is passed.

« no previous file with comments | « no previous file | LayoutTests/fast/events/constructors/composition-event-constructor-expected.txt » ('j') | Source/bindings/v8/Dictionary.h » ('J')