Source/bindings/tests/results/V8TestExtendedEvent.h - Issue 85263002: Improve handling of dictionary conversions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/tests/results/V8TestExtendedEvent.h

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have conversion methods take a context argument; elaborate error msgs further. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/bindings/tests/results/V8TestEventConstructor.cpp ('k') | Source/bindings/tests/results/V8TestExtendedEvent.cpp » ('j') | Source/bindings/v8/Dictionary.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 141 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
152 {	152 {

153 v8SetReturnValueForMainWorld(callbackInfo, impl.get());	153 v8SetReturnValueForMainWorld(callbackInfo, impl.get());

154 }	154 }

155	155

156 template<class CallbackInfo, class Wrappable>	156 template<class CallbackInfo, class Wrappable>

157 inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo, PassRefPtr<Ev ent > impl, Wrappable* wrappable)	157 inline void v8SetReturnValueFast(const CallbackInfo& callbackInfo, PassRefPtr<Ev ent > impl, Wrappable* wrappable)

158 {	158 {

159 v8SetReturnValueFast(callbackInfo, impl.get(), wrappable);	159 v8SetReturnValueFast(callbackInfo, impl.get(), wrappable);

160 }	160 }

161	161

162 bool fillEventInit(EventInit&, const Dictionary&);	162 bool fillEventInit(EventInit&, const Dictionary&, ExceptionState&, const String& = "");

163	163

164 }	164 }

165 #endif // ENABLE(TEST)	165 #endif // ENABLE(TEST)

166 #endif // V8TestExtendedEvent_h	166 #endif // V8TestExtendedEvent_h

OLD	NEW