Source/bindings/v8/ExceptionMessages.h - Issue 85263002: Improve handling of dictionary conversions.

Side by Side Diff: Source/bindings/v8/ExceptionMessages.h

Issue 85263002: Improve handling of dictionary conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/bindings/v8/Dictionary.cpp ('K') | « Source/bindings/v8/Dictionary.cpp ('k') | Source/bindings/v8/ExceptionMessages.cpp » ('j') | Source/core/events/MessageEvent.cpp » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 24 matching lines...) Expand all Loading...
35	35

36 namespace WebCore {	36 namespace WebCore {

37	37

38 class ExceptionMessages {	38 class ExceptionMessages {

39 public:	39 public:

40 static String failedToConstruct(const String& type, const String& detail = S tring());	40 static String failedToConstruct(const String& type, const String& detail = S tring());

41 static String failedToExecute(const String& method, const String& type, cons t String& detail = String());	41 static String failedToExecute(const String& method, const String& type, cons t String& detail = String());

42 static String failedToGet(const String& property, const String& type, const String& detail);	42 static String failedToGet(const String& property, const String& type, const String& detail);

43 static String failedToSet(const String& property, const String& type, const String& detail);	43 static String failedToSet(const String& property, const String& type, const String& detail);

44 static String failedToDelete(const String& property, const String& type, con st String& detail);	44 static String failedToDelete(const String& property, const String& type, con st String& detail);

	45 static String illTypedProperty(const String& property, const String& detail) ;
	Mike West 2013/11/25 08:22:48 How about "incorrectPropertyType" instead? "Ill-ty How about "incorrectPropertyType" instead? "Ill-typed" is nicely poetic, but I worry that it might not be as comprehensible. :) sof 2013/11/25 23:24:05 Done. Interesting, this is standard terminology in Show quoted text On 2013/11/25 08:22:48, Mike West wrote: > How about "incorrectPropertyType" instead? "Ill-typed" is nicely poetic, but I > worry that it might not be as comprehensible. :) Done. Interesting, this is standard terminology in Haskell (my background and language of preference) for something that doesn't "type."
45	46

46 // If > 0, the argument index that failed type check (1-indexed.)	47 // If > 0, the argument index that failed type check (1-indexed.)

47 // If == 0, a (non-argument) value (e.g., a setter) failed the same check.	48 // If == 0, a (non-argument) value (e.g., a setter) failed the same check.

48 static String notAnArrayTypeArgumentOrValue(int argumentIndex);	49 static String notAnArrayTypeArgumentOrValue(int argumentIndex);

49 static String notASequenceTypeProperty(const String& propertyName);	50 static String notASequenceTypeProperty(const String& propertyName);

50 static String notAFiniteNumber(double value);	51 static String notAFiniteNumber(double value);

51	52

52 static String notEnoughArguments(unsigned expected, unsigned providedleastNu mMandatoryParams);	53 static String notEnoughArguments(unsigned expected, unsigned providedleastNu mMandatoryParams);

53	54

54 private:	55 private:

55 static String ordinalNumber(int number);	56 static String ordinalNumber(int number);

56 };	57 };

57	58

58 } // namespace WebCore	59 } // namespace WebCore

59	60

60 #endif // ExceptionMessages_h	61 #endif // ExceptionMessages_h

OLD	NEW