Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 852623002: Call test methods from shared_app_state (Closed)

Created:
5 years, 11 months ago by slamm
Modified:
5 years, 11 months ago
Reviewers:
ariblue, nednguyen
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Call test methods from shared_app_state BUG= Committed: https://crrev.com/3fa6ade8a85463246729b9001dc08418c0de8254 Cr-Commit-Position: refs/heads/master@{#311351}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix DidRunUserStory. Drop tracing_controller temp reference. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M tools/telemetry/telemetry/user_story/android/shared_app_state.py View 1 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
nednguyen
lgtm
5 years, 11 months ago (2015-01-13 21:25:29 UTC) #3
nednguyen
https://codereview.chromium.org/852623002/diff/1/tools/telemetry/telemetry/user_story/android/shared_app_state.py File tools/telemetry/telemetry/user_story/android/shared_app_state.py (right): https://codereview.chromium.org/852623002/diff/1/tools/telemetry/telemetry/user_story/android/shared_app_state.py#newcode68 tools/telemetry/telemetry/user_story/android/shared_app_state.py:68: self._test.WillDidRunUserStory(tracing_controller) self._test.DidRunUserStory(..)
5 years, 11 months ago (2015-01-13 21:26:09 UTC) #4
slamm
Fix DidRunUserStory. Drop tracing_controller temp reference.
5 years, 11 months ago (2015-01-13 21:28:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852623002/20001
5 years, 11 months ago (2015-01-13 21:29:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 22:36:57 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 22:37:43 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3fa6ade8a85463246729b9001dc08418c0de8254
Cr-Commit-Position: refs/heads/master@{#311351}

Powered by Google App Engine
This is Rietveld 408576698