Add |legacy_destination_url| to SessionMessage in CDM_7.

Add |legacy_destination_url| to SessionMessage in CDM_7.

Legacy applications using the prefixed EME API need to have the
destination URL returned, so adding it back in so that it is
available to those applications.

BUG=448242
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293617

[jrummell, 2015-01-13 17:47:46]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, xhwang@chromium.org

[jrummell, 2015-01-13 17:47:47]

PTAL.

[ddorwin, 2015-01-13 18:01:07]

LGTm with suggestions. Thanks!

https://codereview.chromium.org/852553003/diff/1/content_decryption_module.h
File content_decryption_module.h (right):

https://codereview.chromium.org/852553003/diff/1/content_decryption_module.h#...
content_decryption_module.h:1000: // |legacy_destination_url| is included only
for the prefixed API.
nit: For additional clarity and similarity with 1043-5:
"... is only for supporting prefixed EME API and ignored by unprefixed EME."

Should we note that it should only be non-null if message_type is renewal?

[xhwang, 2015-01-13 18:04:14]

Mention CDM_7 in the CL title.

otherwise lgtm % ddorwin's comment.

https://codereview.chromium.org/852553003/diff/1/content_decryption_module.h
File content_decryption_module.h (right):

https://codereview.chromium.org/852553003/diff/1/content_decryption_module.h#...
content_decryption_module.h:1000: // |legacy_destination_url| is included only
for the prefixed API.
On 2015/01/13 18:01:07, ddorwin wrote:
> nit: For additional clarity and similarity with 1043-5:
> "... is only for supporting prefixed EME API and ignored by unprefixed EME."
> 
> Should we note that it should only be non-null if message_type is renewal?

This sounds like implementation detail of specific key systems...

[jrummell, 2015-01-13 18:40:45]

Updated.

https://codereview.chromium.org/852553003/diff/1/content_decryption_module.h
File content_decryption_module.h (right):

https://codereview.chromium.org/852553003/diff/1/content_decryption_module.h#...
content_decryption_module.h:1000: // |legacy_destination_url| is included only
for the prefixed API.
On 2015/01/13 18:01:07, ddorwin wrote:
> nit: For additional clarity and similarity with 1043-5:
> "... is only for supporting prefixed EME API and ignored by unprefixed EME."
> 
> Should we note that it should only be non-null if message_type is renewal?

Done. There is no comment on CDM_6 OnSessionMessage() about what the url is used
for, so left that out.

https://codereview.chromium.org/852553003/diff/1/content_decryption_module.h#...
content_decryption_module.h:1000: // |legacy_destination_url| is included only
for the prefixed API.
On 2015/01/13 18:04:14, xhwang wrote:
> On 2015/01/13 18:01:07, ddorwin wrote:
> > nit: For additional clarity and similarity with 1043-5:
> > "... is only for supporting prefixed EME API and ignored by unprefixed EME."
> > 
> > Should we note that it should only be non-null if message_type is renewal?
> 
> This sounds like implementation detail of specific key systems...
> 

Agreed.

[jrummell, 2015-01-13 18:50:25]

Patchset #3 (id:40001) has been deleted

[jrummell, 2015-01-13 18:51:46]

Added comment about non-null url.

[ddorwin, 2015-01-13 18:58:16]

lgtm

Thanks.

[jrummell, 2015-01-13 19:00:28]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2015-01-13 19:00:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/852553003/60001

[commit-bot: I haz the power, 2015-01-13 19:01:08]

Committed patchset #3 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=293617