Issue 852483002: Add skydb logcat command and make relative build_dir work

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 852483002: Add skydb logcat command and make relative build_dir work (Closed)

Created:
5 years, 11 months ago by eseidel

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add skydb logcat command and make relative build_dir work This fixes 3 little bugs in skydb: 1. Adds a logcat command to make it easy to see android logs 2. Fixes using relative build dirs in skydb start 3. Stops sending /quit to debugger.cc since mojo shutdown doesn't actually work (crashes). --gdb is still broken, but I'll fix that in a second change. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/26f44394148afeabbd88532bf5bbab331c8acbdd

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -12 lines)			Patch
	M	sky/tools/skydb	View		8 chunks	+27 lines, -12 lines	0 comments	Download
	M	sky/tools/skypy/paths.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

eseidel

5 years, 11 months ago (2015-01-12 23:12:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
26f44394148afeabbd88532bf5bbab331c8acbdd (presubmit successful).

Expand Messages | Collapse Messages