chromeos: Make CheckIdleStateIsLocked() query D-Bus client.

chromeos: Make CheckIdleStateIsLocked() query D-Bus client.

Make the Chrome OS implementation of
CheckIdleStateIsLocked() (used by the chrome.idle API) get
the lock state from chromeos::SessionManagerClient instead
of depending on ash::SessionStateDelegate (which reaches
into chrome/browser/chromeos/login/). This makes it possible
for the idle code to be later moved under ui/base/ instead
of living in chrome/browser/, permitting the chrome.idle API
to be moved from chrome/ to extensions/.

As part of this, make SessionManagerClient cache the
most-recently-received-from-session_manager screen-lock
state. Previously it just passed state updates to its
observers, but the idle functions lack a class that can
register itself as an observer.

BUG=446320
Committed: https://crrev.com/85e90a06749fe630317eb01ca3487d5a78e9c10a
Cr-Commit-Position: refs/heads/master@{#311333}

[Daniel Erat, 2015-01-13 00:04:06]

derat@chromium.org changed reviewers:
+ satorux@chromium.org, sky@chromium.org, stevenjb@chromium.org

[Daniel Erat, 2015-01-13 00:04:07]

Steven and Satoru, please take a look at chromeos/.

Scott, please look at chrome/browser/idle_chromeos.cc.

https://codereview.chromium.org/852453005/diff/1/chrome/browser/idle_chromeos.cc
File chrome/browser/idle_chromeos.cc (right):

https://codereview.chromium.org/852453005/diff/1/chrome/browser/idle_chromeos...
chrome/browser/idle_chromeos.cc:8: #include
"chromeos/dbus/dbus_thread_manager.h"
if ui/base/ shouldn't be able to depend on chromeos/, or if this code doesn't
seem like it belongs under ui/base/, i could probably also move it to
components/idle/ or something like that in the next change rather than ui/base/.

[sky, 2015-01-13 00:15:36]

chromeos is suppose to be low level non-ui, so a dep from ui to chromeos seems
fine. Assuming there are no cycles, LGTM.

[stevenjb, 2015-01-13 17:30:12]

lgtm

https://codereview.chromium.org/852453005/diff/1/chrome/browser/idle_chromeos.cc
File chrome/browser/idle_chromeos.cc (right):

https://codereview.chromium.org/852453005/diff/1/chrome/browser/idle_chromeos...
chrome/browser/idle_chromeos.cc:8: #include
"chromeos/dbus/dbus_thread_manager.h"
On 2015/01/13 00:04:07, Daniel Erat wrote:
> if ui/base/ shouldn't be able to depend on chromeos/, or if this code doesn't
> seem like it belongs under ui/base/, i could probably also move it to
> components/idle/ or something like that in the next change rather than
ui/base/.

I have no particular problem with ui/base relying on src/chromeos. That said, we
do also have a ui/chromeos directory which already has that dependency if this
would fit nicely there.

[Daniel Erat, 2015-01-13 17:34:40]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2015-01-13 17:35:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/852453005/1

[commit-bot: I haz the power, 2015-01-13 18:14:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-13 18:14:12]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Daniel Erat, 2015-01-13 18:58:51]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2015-01-13 18:59:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/852453005/20001

[Daniel Erat, 2015-01-13 19:15:51]

The CQ bit was checked by derat@chromium.org

[commit-bot: I haz the power, 2015-01-13 19:17:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/852453005/40001

[commit-bot: I haz the power, 2015-01-13 21:47:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-13 21:48:38]

Patchset 3 (id:??) landed as
https://crrev.com/85e90a06749fe630317eb01ca3487d5a78e9c10a
Cr-Commit-Position: refs/heads/master@{#311333}