[Android] Upstream scene layers

[Android] Upstream scene layers

BUG=426119
Committed: https://crrev.com/50ccaed720664a2b254706231b7d227cc0ff7ae7
Cr-Commit-Position: refs/heads/master@{#311392}

[Changwan Ryu, 2015-01-12 10:10:57]

changwan@chromium.org changed reviewers:
+ dtrainor@chromium.org, jaekyun@chromium.org

[Jaekyun Seok (inactive), 2015-01-13 08:21:22]

https://codereview.chromium.org/852433002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java
(right):

https://codereview.chromium.org/852433002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java:225:
* Helper function that gather the static constants from values/dimens.xml.
Don't we need to add a blank line between comments and @param/@return?

https://codereview.chromium.org/852433002/diff/20001/chrome/browser/android/c...
File chrome/browser/android/compositor/scene_layer/scene_layer.h (right):

https://codereview.chromium.org/852433002/diff/20001/chrome/browser/android/c...
chrome/browser/android/compositor/scene_layer/scene_layer.h:35: 
Don't we need to write comments for public members?

[Changwan Ryu, 2015-01-13 10:18:00]

https://codereview.chromium.org/852433002/diff/20001/chrome/android/java/src/...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java
(right):

https://codereview.chromium.org/852433002/diff/20001/chrome/android/java/src/...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/components/LayoutTab.java:225:
* Helper function that gather the static constants from values/dimens.xml.
On 2015/01/13 08:21:22, Jaekyun Seok wrote:
> Don't we need to add a blank line between comments and @param/@return?

Done.

By the way, I found that that's not how we're doing now:
https://code.google.com/p/chromium/codesearch#search/&q=android%20@param%20-a...

Also chromium-style-5.0.xml does not have it (JavadocParagraph).
But I generally agree that adding a blank line is better.

https://codereview.chromium.org/852433002/diff/20001/chrome/browser/android/c...
File chrome/browser/android/compositor/scene_layer/scene_layer.h (right):

https://codereview.chromium.org/852433002/diff/20001/chrome/browser/android/c...
chrome/browser/android/compositor/scene_layer/scene_layer.h:35: 
On 2015/01/13 08:21:22, Jaekyun Seok wrote:
> Don't we need to write comments for public members?

Done.

[David Trainor- moved to gerrit, 2015-01-13 18:57:20]

looks like mostly a move.  lgtm

https://chromiumcodereview.appspot.com/852433002/diff/40001/chrome/browser/an...
File chrome/browser/android/compositor/scene_layer/scene_layer.h (right):

https://chromiumcodereview.appspot.com/852433002/diff/40001/chrome/browser/an...
chrome/browser/android/compositor/scene_layer/scene_layer.h:38: virtual void
OnDetach();
Maybe add a TODO to investigate if we still need this.

[Changwan Ryu, 2015-01-14 00:55:26]

https://chromiumcodereview.appspot.com/852433002/diff/40001/chrome/browser/an...
File chrome/browser/android/compositor/scene_layer/scene_layer.h (right):

https://chromiumcodereview.appspot.com/852433002/diff/40001/chrome/browser/an...
chrome/browser/android/compositor/scene_layer/scene_layer.h:38: virtual void
OnDetach();
On 2015/01/13 18:57:19, David Trainor wrote:
> Maybe add a TODO to investigate if we still need this.

Done.

[Changwan Ryu, 2015-01-14 00:55:34]

The CQ bit was checked by changwan@chromium.org

[commit-bot: I haz the power, 2015-01-14 00:57:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/852433002/80001

[commit-bot: I haz the power, 2015-01-14 02:07:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-01-14 02:08:09]

Patchset 5 (id:??) landed as
https://crrev.com/50ccaed720664a2b254706231b7d227cc0ff7ae7
Cr-Commit-Position: refs/heads/master@{#311392}