Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 8524019: Linux: Use --embed for dialogs on KDE3; Clean up dialogs_kde.cc. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Visibility:
Public.

Description

Linux: Use --embed for dialogs on KDE3; Clean up dialogs_kde.cc. BUG=101265 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109576

Patch Set 1 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -48 lines) Patch
M chrome/browser/ui/gtk/dialogs_common.h View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/dialogs_common.cc View 3 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/gtk/dialogs_kde.cc View 9 chunks +41 lines, -39 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
9 years, 1 month ago (2011-11-11 01:47:04 UTC) #1
Elliot Glaysher
lgtm
9 years, 1 month ago (2011-11-11 02:28:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8524019/4001
9 years, 1 month ago (2011-11-11 02:29:06 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-11 03:36:19 UTC) #4
Change committed as 109576

Powered by Google App Engine
This is Rietveld 408576698