Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 852383002: Plugin Power Saver: Rename BLOCK to 'Let me choose...' and UI tweaks. (Closed)

Created:
5 years, 11 months ago by tommycli
Modified:
5 years, 11 months ago
Reviewers:
stevenjb, James Hawkins
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Rename BLOCK to 'Let me choose when to run plugin content' and UI tweaks. Other tweaks: "Manage individual plug-ins..." for about:plugins link "Always allowed to run" within about:plugins BUG=403800 Committed: https://crrev.com/8f69d27835cb3e1b4ac88047d7ff561f9af96f20 Cr-Commit-Position: refs/heads/master@{#312883}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/content_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
tommycli
stevenjb: May I have a review? (Also pending https://groups.google.com/a/google.com/forum/#!topic/chrome-ui-review/UcXREa30nW8)
5 years, 11 months ago (2015-01-16 22:56:15 UTC) #2
stevenjb
The code changes lgtm +jhawkins@ : Is there anyone else who should be aware of ...
5 years, 11 months ago (2015-01-20 21:49:37 UTC) #4
James Hawkins
On 2015/01/20 21:49:37, stevenjb wrote: > The code changes lgtm > > +jhawkins@ : Is ...
5 years, 11 months ago (2015-01-20 22:04:36 UTC) #5
tommycli
On 2015/01/20 22:04:36, James Hawkins wrote: > On 2015/01/20 21:49:37, stevenjb wrote: > > The ...
5 years, 11 months ago (2015-01-22 00:34:18 UTC) #6
stevenjb
On 2015/01/20 22:04:36, James Hawkins wrote: > On 2015/01/20 21:49:37, stevenjb wrote: > > The ...
5 years, 11 months ago (2015-01-22 01:48:00 UTC) #7
James Hawkins
Meh, I think you're probably fine to review string changes as long as you check ...
5 years, 11 months ago (2015-01-22 21:43:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852383002/40001
5 years, 11 months ago (2015-01-23 17:49:59 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-23 18:45:38 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 18:46:29 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8f69d27835cb3e1b4ac88047d7ff561f9af96f20
Cr-Commit-Position: refs/heads/master@{#312883}

Powered by Google App Engine
This is Rietveld 408576698