Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 852313002: Add fast-path OOB support to KeyedLoadIC_Generic (Closed)

Created:
5 years, 11 months ago by Jakob Kummerow
Modified:
5 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add fast-path OOB support to KeyedLoadIC_Generic R=verwaest@chromium.org Committed: https://crrev.com/79ed8f173ce1624f6d7821ea6b44ce75efa97912 Cr-Commit-Position: refs/heads/master@{#26111}

Patch Set 1 #

Patch Set 2 : arm: s/b(al, ...)/jmp/ #

Patch Set 3 : fix negative indices #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -98 lines) Patch
M src/ic/arm/ic-arm.cc View 1 2 4 chunks +45 lines, -24 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 1 2 2 chunks +49 lines, -35 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 1 2 2 chunks +43 lines, -18 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 1 2 4 chunks +44 lines, -21 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Jakob Kummerow
PTAL.
5 years, 11 months ago (2015-01-16 13:51:44 UTC) #1
Toon Verwaest
lgtm
5 years, 11 months ago (2015-01-16 14:19:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852313002/20001
5 years, 11 months ago (2015-01-16 14:33:15 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2129)
5 years, 11 months ago (2015-01-16 14:53:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852313002/40002
5 years, 11 months ago (2015-01-16 17:34:06 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40002)
5 years, 11 months ago (2015-01-16 22:18:56 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 22:19:04 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/79ed8f173ce1624f6d7821ea6b44ce75efa97912
Cr-Commit-Position: refs/heads/master@{#26111}

Powered by Google App Engine
This is Rietveld 408576698