Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 852263004: X87: add stub for api function calls with known number of parameters (Closed)

Created:
5 years, 11 months ago by chunyang.dai
Modified:
5 years, 11 months ago
Reviewers:
Weiliang, dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: add stub for api function calls with known number of parameters port 8c990d1716d33db4834b7e3c115874d482291e8c original commit message: add stub for api function calls with known number of parameters BUG= R=weiliang.lin@intel.com Committed: https://crrev.com/76d62e836a876251aa459920d60aa0392f16cf6d Cr-Commit-Position: refs/heads/master@{#26148}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x87/code-stubs-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
chunyang.dai
WL. PTAL. thanks
5 years, 11 months ago (2015-01-20 05:28:23 UTC) #2
Weiliang
lgtm
5 years, 11 months ago (2015-01-20 06:23:53 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/76d62e836a876251aa459920d60aa0392f16cf6d Cr-Commit-Position: refs/heads/master@{#26148}
5 years, 11 months ago (2015-01-20 06:49:08 UTC) #4
chunyang.dai
5 years, 11 months ago (2015-01-20 06:49:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
76d62e836a876251aa459920d60aa0392f16cf6d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698