Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 852233002: VTTCue: Simplify computation of direction-aware text position (Closed)

Created:
5 years, 11 months ago by fs
Modified:
5 years, 11 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, gasubic, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

VTTCue: Simplify computation of direction-aware text position Add a helper resolveCueAlignment to resolve 'start' and 'end' to the corresponding "visual" value, and also compute the visual text position once. BUG=448000 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -25 lines) Patch
M Source/core/html/track/vtt/VTTCue.cpp View 2 chunks +19 lines, -25 lines 0 comments Download

Messages

Total messages: 12 (2 generated)
fs
5 years, 11 months ago (2015-01-15 18:11:05 UTC) #2
philipj_slow
Would this not be made obsolete by implementing http://dev.w3.org/html5/webvtt/#dfn-text-track-cue-computed-text-position per spec? The spec was changed ...
5 years, 11 months ago (2015-01-16 13:37:42 UTC) #3
fs
On 2015/01/16 13:37:42, philipj wrote: > Would this not be made obsolete by implementing > ...
5 years, 11 months ago (2015-01-16 13:57:15 UTC) #4
philipj_slow
Hmm, the "Determine the value of maximum size for cue as per the appropriate rules ...
5 years, 11 months ago (2015-01-16 14:08:34 UTC) #5
fs
On 2015/01/16 14:08:34, philipj wrote: > Hmm, the "Determine the value of maximum size for ...
5 years, 11 months ago (2015-01-16 14:19:53 UTC) #6
philipj_slow
Right, it's positionAlign that gives rise to "text track cue computed text position alignment". I'm ...
5 years, 11 months ago (2015-01-16 14:43:23 UTC) #7
fs
On 2015/01/16 14:43:23, philipj wrote: > Right, it's positionAlign that gives rise to "text track ...
5 years, 11 months ago (2015-01-16 15:03:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852233002/1
5 years, 11 months ago (2015-01-16 15:04:22 UTC) #10
philipj_slow
On 2015/01/16 15:03:55, fs wrote: > On 2015/01/16 14:43:23, philipj wrote: > > Right, it's ...
5 years, 11 months ago (2015-01-16 15:07:38 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 21:51:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188545

Powered by Google App Engine
This is Rietveld 408576698