Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 852213002: SkPictureShader should handle negative scaling gracefully. (Closed)

Created:
5 years, 11 months ago by f(malita)
Modified:
5 years, 11 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org, fs
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPictureShader should handle negative scaling gracefully. Let's not choke on inverted tiles. BUG=chromium:447707 R=robertphillips@google.com,reed@google.com Committed: https://skia.googlesource.com/skia/+/b0878797b45f93b3bfe6084094c74affd10207df

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rerebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M gm/pictureshader.cpp View 2 chunks +23 lines, -1 line 0 comments Download
M src/core/SkPictureShader.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
f(malita)
5 years, 11 months ago (2015-01-15 16:03:47 UTC) #1
robertphillips
lgtm
5 years, 11 months ago (2015-01-15 16:39:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852213002/20001
5 years, 11 months ago (2015-01-15 16:55:03 UTC) #4
commit-bot: I haz the power
Failed to apply patch for expectations/gm/ignored-tests.txt: While running git apply --index -3 -p1; error: patch ...
5 years, 11 months ago (2015-01-15 18:16:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852213002/40001
5 years, 11 months ago (2015-01-15 18:36:30 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 18:46:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/b0878797b45f93b3bfe6084094c74affd10207df

Powered by Google App Engine
This is Rietveld 408576698