Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 852203003: Add Xfer Processor for GrCustomXfermodes (Closed)

Created:
5 years, 11 months ago by egdaniel
Modified:
5 years, 11 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@xferMover
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add Xfer Processor for GrCustomXfermodes BUG=skia: Committed: https://skia.googlesource.com/skia/+/54f0e9d784122cfd3f5968e0fea971d5b5a4805a

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -25 lines) Patch
M expectations/gm/ignored-tests.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
M include/gpu/effects/GrCustomXfermode.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 1 chunk +11 lines, -0 lines 0 comments Download
M src/core/SkXfermode_proccoeff.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 3 chunks +110 lines, -23 lines 0 comments Download
M src/gpu/effects/GrCustomXfermodePriv.h View 1 2 2 chunks +93 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
egdaniel
With this cl we will have an XP for all current xfermodes
5 years, 11 months ago (2015-01-15 19:07:55 UTC) #2
bsalomon
lgtm
5 years, 11 months ago (2015-01-15 19:24:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852203003/20001
5 years, 11 months ago (2015-01-16 14:13:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1529)
5 years, 11 months ago (2015-01-16 14:15:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852203003/40001
5 years, 11 months ago (2015-01-16 14:20:51 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 14:29:51 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/54f0e9d784122cfd3f5968e0fea971d5b5a4805a

Powered by Google App Engine
This is Rietveld 408576698