Issue 852153003: Revert of [turbofan] Use PlainPrimitiveToNumber whenever possible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 852153003: Revert of [turbofan] Use PlainPrimitiveToNumber whenever possible. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer

Modified:
5 years, 11 months ago

Reviewers:
dcarney, Jarin

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Revert of [turbofan] Use PlainPrimitiveToNumber whenever possible. (patchset #1 id:1 of https://codereview.chromium.org/852763002/) Reason for revert: Tanks performance of SQLite and towers.c. Original issue's description: > [turbofan] Use PlainPrimitiveToNumber whenever possible. > > TEST=cctest,unittests > R=jarin@chromium.org > > Committed: https://crrev.com/1a5db24e6bf831e61e3f4aa0c252f77e48c3689c > Cr-Commit-Position: refs/heads/master@{#26071} TBR=jarin@chromium.org,dcarney@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/49147163879852e5ba951b5455956f227e8f4711 Cr-Commit-Position: refs/heads/master@{#26078}

Created: 5 years, 11 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+36 lines, -18 lines)			Patch
M	src/compiler/js-typed-lowering.cc	View	6 chunks	+32 lines, -12 lines	0 comments	Download
M	test/cctest/compiler/test-js-typed-lowering.cc	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	test/unittests/compiler/js-typed-lowering-unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/unittests/compiler/node-test-utils.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	test/unittests/compiler/node-test-utils.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Benedikt Meurer

Created Revert of [turbofan] Use PlainPrimitiveToNumber whenever possible.

5 years, 11 months ago (2015-01-15 13:26:12 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852153003/1

5 years, 11 months ago (2015-01-15 13:26:36 UTC) #2

commit-bot: I haz the power

5 years, 11 months ago (2015-01-15 13:27:02 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/49147163879852e5ba951b5455956f227e8f4711
Cr-Commit-Position: refs/heads/master@{#26078}