Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: mojo/edk/system/channel.h

Issue 852113002: Remove RawChannel::Init() and Channel::Init() failure cases. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/edk/embedder/embedder.cc ('k') | mojo/edk/system/channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/edk/system/channel.h
diff --git a/mojo/edk/system/channel.h b/mojo/edk/system/channel.h
index 64acb7d22b1768a4cfba2a2e5fdb276b64fcbb73..396185908dd48b1f989425198bb61ac00a66e6f8 100644
--- a/mojo/edk/system/channel.h
+++ b/mojo/edk/system/channel.h
@@ -60,9 +60,8 @@ class MOJO_SYSTEM_IMPL_EXPORT Channel
// This must be called on the creation thread before any other methods are
// called, and before references to this object are given to any other
- // threads. |raw_channel| should be uninitialized. Returns true on success. On
- // failure, no other methods should be called (including |Shutdown()|).
- bool Init(scoped_ptr<RawChannel> raw_channel);
+ // threads. |raw_channel| should be uninitialized.
+ void Init(scoped_ptr<RawChannel> raw_channel);
// Sets the channel manager associated with this channel. This should be set
// at most once and only called before |WillShutdownSoon()| (and
« no previous file with comments | « mojo/edk/embedder/embedder.cc ('k') | mojo/edk/system/channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698