Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 852073002: IndexedDB: Revert change to enable reuse of leveldb manifest in IDB (take 2). (Closed)

Created:
5 years, 11 months ago by cmumford
Modified:
5 years, 11 months ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IndexedDB: Revert change to enable reuse of leveldb manifest in IDB (take 2). The prior revert (ca6c875) of the leveldb manifest reuse change (de701ab) was insufficient because there appears to be a bug in leveldb where it fails to consult the reuse_logs option. So if the Env has a working NewAppendableFile method then leveldb will always try to reuse it's manifest. Deleting our version of this function so that the base Env implementation will be called (which fails forcing no-reuse). BUG=402980, 395799 Committed: https://crrev.com/617e94e4e3b423579ecebc1c01e07bfbd603694d Cr-Commit-Position: refs/heads/master@{#311576}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M third_party/leveldatabase/env_chromium.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cmumford
PTAL
5 years, 11 months ago (2015-01-14 21:28:33 UTC) #2
jsbell
lgtm
5 years, 11 months ago (2015-01-14 21:29:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852073002/1
5 years, 11 months ago (2015-01-14 22:51:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 23:54:01 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 23:54:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/617e94e4e3b423579ecebc1c01e07bfbd603694d
Cr-Commit-Position: refs/heads/master@{#311576}

Powered by Google App Engine
This is Rietveld 408576698