Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 852053002: Fix dangling reference in NormalSpdyTransactionHelper. (Closed)

Created:
5 years, 11 months ago by Bence
Modified:
5 years, 11 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix dangling reference in NormalSpdyTransactionHelper. NormalSpdyTransactionHelper constructor is often (approximately 70 times) called with a temporary BoundNetLog() argument. Its log_ member currently takes reference of that, which becomes dangling right after the constructor returns. This is not an issue if there are no NetLog events, nor in the NetLog test which creates a named CapturingBoundNetLog object that it keeps in scope. The dangling reference only became problematic in the HTTP11RequiredProxyRetry test, and curiously enough, only for 64 bit Andoid builds. This CL changes the NormalSpdyTransactionHelper.log_ member type from reference to value to fix this issue. BUG=447837 Committed: https://crrev.com/29b1f07f9291ca0358117efb691cae9ae6ded989 Cr-Commit-Position: refs/heads/master@{#311538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/spdy/spdy_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Bence
mmenke: PTAL. Thank you.
5 years, 11 months ago (2015-01-14 18:53:50 UTC) #2
mmenke
On 2015/01/14 18:53:50, Bence wrote: > mmenke: PTAL. Thank you. LGTM
5 years, 11 months ago (2015-01-14 18:54:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/852053002/1
5 years, 11 months ago (2015-01-14 20:33:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 20:38:18 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/29b1f07f9291ca0358117efb691cae9ae6ded989 Cr-Commit-Position: refs/heads/master@{#311538}
5 years, 11 months ago (2015-01-14 20:39:39 UTC) #7
Ryan Hamilton
On 2015/01/14 18:54:24, mmenke wrote: > On 2015/01/14 18:53:50, Bence wrote: > > mmenke: PTAL. ...
5 years, 11 months ago (2015-01-15 20:31:41 UTC) #8
Bence
5 years, 11 months ago (2015-01-15 20:49:55 UTC) #9
Message was sent while issue was closed.
On 2015/01/15 20:31:41, Ryan Hamilton wrote:
> On 2015/01/14 18:54:24, mmenke wrote:
> > On 2015/01/14 18:53:50, Bence wrote:
> > > mmenke: PTAL.  Thank you.
> > 
> > LGTM
> 
> Nice catch! Do you think this was the same issue we saw with the other
> HTTP_1_1_REQUIRED test? If so, is it worth trying that tests again?

Good call, I'll try.

Powered by Google App Engine
This is Rietveld 408576698