chrome/browser/ui/views/download/download_item_view.cc - Issue 852043002: Initial Implementation of Download Notification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/download/download_item_view.cc

Issue 852043002: Initial Implementation of Download Notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed build & test errors on non-ChromeOS platform. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/download/download_item_view.cc

diff --git a/chrome/browser/ui/views/download/download_item_view.cc b/chrome/browser/ui/views/download/download_item_view.cc

index 7a7f2693022d55d002c4068d2c0c2b6a1caa73fe..05021166db170e3a78dd6f51ed9068a85a41036c 100644

--- a/chrome/browser/ui/views/download/download_item_view.cc

+++ b/chrome/browser/ui/views/download/download_item_view.cc

@@ -1034,10 +1034,9 @@ void DownloadItemView::ShowContextMenuImpl(const gfx::Point& p,

weak_ptr_factory_.GetWeakPtr()));

views::View::ConvertPointToScreen(this, &point);

- if (!context_menu_.get()) {

- context_menu_.reset(

- new DownloadShelfContextMenuView(download(), shelf_->GetNavigator()));

- }

+ if (!context_menu_.get())

+ context_menu_.reset(new DownloadShelfContextMenuView(download()));

context_menu_->Run(GetWidget()->GetTopLevelWidget(),

gfx::Rect(point, size), source_type);

// We could be deleted now.