Initial Implementation of Download Notification

chrome/browser/download/download_commands.cc

Index: chrome/browser/download/download_commands.cc
diff --git a/chrome/browser/download/download_commands.cc b/chrome/browser/download/download_commands.cc
new file mode 100644
index 0000000000000000000000000000000000000000..36f5411881750c97c8232abceaa5c9f5f5929446
--- /dev/null
+++ b/chrome/browser/download/download_commands.cc
@@ -0,0 +1,253 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/download/download_commands.h"
+
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/download/download_crx_util.h"
+#include "chrome/browser/download/download_item_model.h"
+#include "chrome/browser/download/download_prefs.h"
+#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/safe_browsing/download_protection_service.h"
+#include "chrome/browser/safe_browsing/safe_browsing_service.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/common/url_constants.h"
+#include "chrome/grit/generated_resources.h"
+#include "grit/theme_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/base/resource/resource_bundle.h"
+
+#if defined(OS_WIN)
+#include "chrome/browser/download/download_target_determiner.h"
+#include "chrome/browser/ui/pdf/adobe_reader_info_win.h"
+#endif
+
+DownloadCommands::DownloadCommands(content::DownloadItem* download_item)
+    : download_item_(download_item) {
+}
+
+int DownloadCommands::GetCommandIconId(Command command) {
+  switch (command) {
+    case PAUSE:
+      return IDR_DOWNLOAD_NOTIFICATION_MENU_PAUSE;
+    case RESUME:
+      return IDR_DOWNLOAD_NOTIFICATION_MENU_RESUME;
+    case SHOW_IN_FOLDER:
+      return IDR_DOWNLOAD_NOTIFICATION_MENU_FOLDER;
+    case RETRY:
+    case KEEP:
+      return IDR_DOWNLOAD_NOTIFICATION_MENU_DOWNLOAD;
+    case DISCARD:
+      return IDR_DOWNLOAD_NOTIFICATION_MENU_DELETE;
+    case OPEN_WHEN_COMPLETE:
+    case ALWAYS_OPEN_TYPE:
+    case PLATFORM_OPEN:
+    case CANCEL:
+    case LEARN_MORE_SCANNING:
+    case LEARN_MORE_INTERRUPTED:
+      return -1;
+  }
+  NOTREACHED();
+  return -1;
+}
+
+gfx::Image DownloadCommands::GetCommandIcon(Command command) {
+  ResourceBundle& bundle = ResourceBundle::GetSharedInstance();
+  return bundle.GetImageNamed(GetCommandIconId(command));
+}
+
+bool DownloadCommands::IsCommandEnabled(Command command) const {
+  if (!download_item_)

[asanka, 2015/02/27 01:26:48]

download_item_ should never be nullptr. Here and elsewhere in DownloadCommand.

[yoshiki, 2015/02/28 10:50:53]

Done.

+    return false;
+
+  switch (command) {
+    case SHOW_IN_FOLDER:
+      return download_item_->CanShowInFolder();
+    case OPEN_WHEN_COMPLETE:
+    case PLATFORM_OPEN:
+      return download_item_->CanOpenDownload() &&
+             !download_crx_util::IsExtensionDownload(*download_item_);
+    case ALWAYS_OPEN_TYPE:
+      // For temporary downloads, the target filename might be a temporary
+      // filename. Don't base an "Always open" decision based on it. Also
+      // exclude extensions.
+      return download_item_->CanOpenDownload() &&
+             !download_crx_util::IsExtensionDownload(*download_item_);
+    case CANCEL:
+      return !download_item_->IsDone();
+    case PAUSE:
+      return !download_item_->IsDone() && !download_item_->IsPaused() &&
+             download_item_->GetState() == content::DownloadItem::IN_PROGRESS;
+    case RESUME:
+      return !download_item_->IsDone() &&

[asanka, 2015/02/27 01:26:48]

Use download_item_->CanResume()

[yoshiki, 2015/02/28 10:50:53]

Done.

+             (download_item_->IsPaused() ||
+              download_item_->GetState() != content::DownloadItem::IN_PROGRESS);
+    case DISCARD:
+    case KEEP:
+    case LEARN_MORE_SCANNING:
+    case LEARN_MORE_INTERRUPTED:
+    case RETRY:
+      return true;
+  }
+  NOTREACHED();
+  return false;
+}
+
+bool DownloadCommands::IsCommandChecked(Command command) const {
+  if (!download_item_)
+    return false;
+
+  switch (command) {
+    case OPEN_WHEN_COMPLETE:
+      return download_item_->GetOpenWhenComplete() ||
+             download_crx_util::IsExtensionDownload(*download_item_);
+    case ALWAYS_OPEN_TYPE:
+#if defined(OS_WIN) || defined(OS_LINUX) || \
+    (defined(OS_MACOSX) && !defined(OS_IOS))
+      if (CanOpenPdfInSystemViewer()) {
+        DownloadPrefs* prefs = DownloadPrefs::FromBrowserContext(
+            download_item_->GetBrowserContext());
+        return prefs->ShouldOpenPdfInSystemReader();
+      }
+#endif
+      return download_item_->ShouldOpenFileBasedOnExtension();
+    case PAUSE:
+    case RESUME:
+      return download_item_->IsPaused();
+    case SHOW_IN_FOLDER:
+    case PLATFORM_OPEN:
+    case CANCEL:
+    case DISCARD:
+    case KEEP:
+    case RETRY:
+    case LEARN_MORE_SCANNING:
+    case LEARN_MORE_INTERRUPTED:
+      return false;
+  }
+  return false;
+}
+
+bool DownloadCommands::IsCommandVisible(Command command) const {
+  if (!download_item_)
+    return false;
+
+  if (command == PLATFORM_OPEN)
+    return (DownloadItemModel(download_item_).ShouldPreferOpeningInBrowser());
+
+  return true;
+}
+
+void DownloadCommands::ExecuteCommand(Command command, Profile* profile) {
+  if (!download_item_)
+    return;
+
+  switch (command) {
+    case SHOW_IN_FOLDER:
+      download_item_->ShowDownloadInShell();
+      break;
+    case OPEN_WHEN_COMPLETE:
+      download_item_->OpenDownload();
+      break;
+    case ALWAYS_OPEN_TYPE: {
+      bool is_checked = IsCommandChecked(ALWAYS_OPEN_TYPE);
+      DownloadPrefs* prefs = DownloadPrefs::FromBrowserContext(
+          download_item_->GetBrowserContext());
+#if defined(OS_WIN) || defined(OS_LINUX) || \
+    (defined(OS_MACOSX) && !defined(OS_IOS))
+      if (CanOpenPdfInSystemViewer()) {
+        prefs->SetShouldOpenPdfInSystemReader(!is_checked);
+        DownloadItemModel(download_item_)
+            .SetShouldPreferOpeningInBrowser(is_checked);
+        break;
+      }
+#endif
+      base::FilePath path = download_item_->GetTargetFilePath();
+      if (is_checked)
+        prefs->DisableAutoOpenBasedOnExtension(path);
+      else
+        prefs->EnableAutoOpenBasedOnExtension(path);
+      break;
+    }
+    case PLATFORM_OPEN:
+      DownloadItemModel(download_item_).OpenUsingPlatformHandler();
+      break;
+    case CANCEL:
+      download_item_->Cancel(true /* Cancelled by user */);
+      break;
+    case DISCARD:
+      download_item_->Remove();
+      break;
+    case KEEP:
+      download_item_->ValidateDangerousDownload();
+      break;
+    case LEARN_MORE_SCANNING: {
+#if defined(FULL_SAFE_BROWSING)
+      using safe_browsing::DownloadProtectionService;
+
+      Browser* browser =
+          g_browser_process->profile_manager()->IsValidProfile(profile)

[asanka, 2015/02/27 01:26:48]

Something is seriously wrong if the profile isn't valid. Why do you think
DownloadCommands would outlive a Profile?

Also, you can use
Profile::FromBrowserContext(download_item_->GetBrowserContext()) to get at the
profile instead of keeping a Profile*.

[yoshiki, 2015/02/28 10:50:53]

Thanks for guidance. I do so. Done.

+              ? chrome::FindBrowserWithProfile(profile,

[asanka, 2015/02/27 01:26:48]

This can return nullptr if there are no active browser windows. Shouldn't we
create a browser window if none exists?

Also, use FindTabbedBrowser() since we don't want to open the help page in a
non-tabbed browser window.

[yoshiki, 2015/02/28 10:50:53]

ScopedTabbedBrowserDisplayer looks good in this case. I use it.

+                                               chrome::GetActiveDesktop())
+              : NULL;
+      if (browser) {
+        SafeBrowsingService* sb_service =
+            g_browser_process->safe_browsing_service();
+        DownloadProtectionService* protection_service =
+            (sb_service ? sb_service->download_protection_service() : NULL);
+        if (protection_service) {

[asanka, 2015/02/27 01:26:48]

Nit: no {

[yoshiki, 2015/02/28 10:50:53]

Done.

+          protection_service->ShowDetailsForDownload(*download_item_, browser);
+        }
+      }
+#else
+      // Should only be getting invoked if we are using safe browsing.
+      NOTREACHED();
+#endif
+      break;
+    }
+    case LEARN_MORE_INTERRUPTED: {
+      Browser* browser =
+          g_browser_process->profile_manager()->IsValidProfile(profile)

[asanka, 2015/02/27 01:26:48]

Same comments as above. Probably move the Browser* lookup code into a separate
function?

[yoshiki, 2015/02/28 10:50:53]

Done.

+              ? chrome::FindBrowserWithProfile(profile,
+                                               chrome::GetActiveDesktop())
+              : NULL;
+      if (browser) {
+        browser->OpenURL(content::OpenURLParams(
+            GURL(chrome::kDownloadInterruptedLearnMoreURL), content::Referrer(),
+            NEW_FOREGROUND_TAB, ui::PAGE_TRANSITION_LINK, false));
+      }
+      break;
+    }
+    case PAUSE:
+      download_item_->Pause();
+      break;
+    case RESUME:
+      download_item_->Resume();
+      break;
+    case RETRY:

[asanka, 2015/02/27 01:26:49]

What do you expect the RETRY command to do? And where is it used?

[yoshiki, 2015/02/28 10:50:53]

It's used when user wants to retry a cancelled or interrupted download.

[asanka, 2015/03/02 22:17:25]

What's the difference between RESUME and RETRY?

[yoshiki, 2015/03/03 04:48:38]

I meant:
- Resume: suspended download
- Retry: cancelled or interrupted download

But I just realized we can reconsider about the difference and behavior. I'll
chat with the PM about it. Thanks!

+      download_item_->Resume();
+      break;
+  }
+}
+
+#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)
+bool DownloadCommands::IsDownloadPdf() const {
+  base::FilePath path = download_item_->GetTargetFilePath();
+  return path.MatchesExtension(FILE_PATH_LITERAL(".pdf"));
+}
+#endif
+
+bool DownloadCommands::CanOpenPdfInSystemViewer() const {
+#if defined(OS_WIN)
+  bool is_adobe_pdf_reader_up_to_date = false;
+  if (IsDownloadPdf() && IsAdobeReaderDefaultPDFViewer()) {
+    is_adobe_pdf_reader_up_to_date =
+        DownloadTargetDeterminer::IsAdobeReaderUpToDate();
+  }
+  return IsDownloadPdf() &&
+         (IsAdobeReaderDefaultPDFViewer() ? is_adobe_pdf_reader_up_to_date
+                                          : true);
+#elif defined(OS_MACOSX) || defined(OS_LINUX)
+  return IsDownloadPdf();
+#endif
+}