Initial Implementation of Download Notification

chrome/browser/download/download_command.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_COMMAND_H_
+#define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_COMMAND_H_
+
+#include "base/strings/string16.h"
+
+#include "content/public/browser/download_item.h"
+#include "content/public/browser/page_navigator.h"
+
+class DownloadCommand {

[asanka, 2015/02/10 02:25:30]

Given how it's used, I'd probably go with DownloadCommands as the class name and
Command as the enum name.

[yoshiki, 2015/02/10 17:49:17]

Thanks for guidance. Done.

+ public:
+  enum Commands {
+    SHOW_IN_FOLDER = 1,    // Open a folder view window with the item selected.
+    OPEN_WHEN_COMPLETE,    // Open the download when it's finished.
+    ALWAYS_OPEN_TYPE,      // Default this file extension to always open.
+    PLATFORM_OPEN,         // Open using platform handler.
+    CANCEL,                // Cancel the download.
+    PAUSE,                 // Pause a download.
+    RESUME,                // Resume a download.
+    DISCARD,               // Discard the malicious download.
+    KEEP,                  // Keep the malicious download.
+    RETRY,                 // Retry the download.
+    LEARN_MORE_SCANNING,   // Show information about download scanning.
+    LEARN_MORE_INTERRUPTED,// Show information about interrupted downloads.
+  };
+
+  explicit DownloadCommand(content::DownloadItem* download_item);
+  virtual ~DownloadCommand() {}
+
+  int GetCommandIconId(Commands type);

[asanka, 2015/02/10 02:25:30]

Taken out of context, methods that return string IDs and icon IDs don't make
sense in this abstraction. The returned IDs are only valid when used in specific
circumstances. This goes for the GetCommandStringId* functions below as well.

We could keep the GetCommandStringId* type methods in the abstractions where the
name is unambigious. I.e. keep GetCommandStringId* logic in
DownloadShelfContextMenu.

[yoshiki, 2015/02/10 17:49:17]

I made these public methods return string16/Image instead of IDs, and kept the
methods which return IDs private.

+
+  int GetCommandStringId(Commands type) const;
+  int GetCommandStringIdForMenu(Commands type) const;
+
+  bool IsCommandIdEnabled(Commands command_id) const;
+  bool IsCommandIdChecked(Commands command_id) const;
+  bool IsCommandIdVisible(Commands command_id) const;
+  void ExecuteCommand(Commands command_id, content::PageNavigator* navigator);
+
+ private:
+#if defined(OS_WIN) || defined(OS_LINUX) || \
+    (defined(OS_MACOSX) && !defined(OS_IOS))
+  bool IsDownloadPdf() const;
+  bool CanOpenPdfInSystemViewer() const;
+#endif
+
+  int GetCommandStringIdInternal(Commands type, bool for_menu) const;
+
+  int GetAlwaysOpenStringId() const;
+
+  content::DownloadItem* download_item_;
+};
+
+#endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_COMMAND_H_