Initial Implementation of Download Notification

chrome/browser/download/download_shelf_context_menu.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_shelf_context_menu.h"
 
 #include "base/command_line.h"
 #include "chrome/browser/browser_process.h"
+#include "chrome/browser/download/download_commands.h"
 #include "chrome/browser/download/download_crx_util.h"
 #include "chrome/browser/download/download_item_model.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/download/download_target_determiner.h"
 #include "chrome/browser/safe_browsing/download_protection_service.h"
 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/download_manager.h"
@@ skipping 60 matching lines @@
     model = GetInterruptedMenuModel();
   else
     model = GetInProgressMenuModel();
   return model;
 }
 
 bool DownloadShelfContextMenu::IsCommandIdEnabled(int command_id) const {
   if (!download_item_)
     return false;
 
-  switch (static_cast<ContextMenuCommands>(command_id)) {
+  switch (static_cast<DownloadCommands>(command_id)) {
     case SHOW_IN_FOLDER:
       return download_item_->CanShowInFolder();
     case OPEN_WHEN_COMPLETE:
     case PLATFORM_OPEN:
       return download_item_->CanOpenDownload() &&
           !download_crx_util::IsExtensionDownload(*download_item_);
     case ALWAYS_OPEN_TYPE:
       // For temporary downloads, the target filename might be a temporary
       // filename. Don't base an "Always open" decision based on it. Also
       // exclude extensions.
       return download_item_->CanOpenDownload() &&
           !download_crx_util::IsExtensionDownload(*download_item_);
     case CANCEL:
       return !download_item_->IsDone();
     case TOGGLE_PAUSE:
       return !download_item_->IsDone();
     case DISCARD:
     case KEEP:
     case LEARN_MORE_SCANNING:
     case LEARN_MORE_INTERRUPTED:
       return true;
+    default:
+      break;
   }
   NOTREACHED();
   return false;
 }
 
 bool DownloadShelfContextMenu::IsCommandIdChecked(int command_id) const {
   if (!download_item_)
     return false;
 
-  switch (command_id) {
+  switch (static_cast<DownloadCommands>(command_id)) {
     case OPEN_WHEN_COMPLETE:
       return download_item_->GetOpenWhenComplete() ||
           download_crx_util::IsExtensionDownload(*download_item_);
     case ALWAYS_OPEN_TYPE:
 #if defined(OS_WIN) || defined(OS_LINUX) || \
     (defined(OS_MACOSX) && !defined(OS_IOS))
       if (CanOpenPdfInSystemViewer()) {
         DownloadPrefs* prefs = DownloadPrefs::FromBrowserContext(
             download_item_->GetBrowserContext());
         return prefs->ShouldOpenPdfInSystemReader();
       }
 #endif
       return download_item_->ShouldOpenFileBasedOnExtension();
     case TOGGLE_PAUSE:
       return download_item_->IsPaused();
+    default:
+      break;
   }
   return false;
 }
 
 bool DownloadShelfContextMenu::IsCommandIdVisible(int command_id) const {
   if (!download_item_)
     return false;
 
   if (command_id == PLATFORM_OPEN)
     return (DownloadItemModel(download_item_).ShouldPreferOpeningInBrowser());
 
   return true;
 }
 
 void DownloadShelfContextMenu::ExecuteCommand(int command_id, int event_flags) {
   if (!download_item_)
     return;
 
-  switch (static_cast<ContextMenuCommands>(command_id)) {
+  switch (static_cast<DownloadCommands>(command_id)) {
     case SHOW_IN_FOLDER:
       download_item_->ShowDownloadInShell();
       break;
     case OPEN_WHEN_COMPLETE:
       download_item_->OpenDownload();
       break;
     case ALWAYS_OPEN_TYPE: {
       bool is_checked = IsCommandIdChecked(ALWAYS_OPEN_TYPE);
       DownloadPrefs* prefs = DownloadPrefs::FromBrowserContext(
           download_item_->GetBrowserContext());
@@ skipping 50 matching lines @@
       break;
     }
     case LEARN_MORE_INTERRUPTED:
       navigator_->OpenURL(
           content::OpenURLParams(GURL(chrome::kDownloadInterruptedLearnMoreURL),
                                  content::Referrer(),
                                  NEW_FOREGROUND_TAB,
                                  ui::PAGE_TRANSITION_LINK,
                                  false));
       break;
+    default:
+      break;
   }
 }
 
 bool DownloadShelfContextMenu::GetAcceleratorForCommandId(
     int command_id, ui::Accelerator* accelerator) {
   return false;
 }
 
 bool DownloadShelfContextMenu::IsItemForCommandIdDynamic(int command_id) const {
   return command_id == TOGGLE_PAUSE;
 }
 
 base::string16 DownloadShelfContextMenu::GetLabelForCommandId(
     int command_id) const {
-  switch (static_cast<ContextMenuCommands>(command_id)) {
+  switch (static_cast<DownloadCommands>(command_id)) {
     case SHOW_IN_FOLDER:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_SHOW);
     case OPEN_WHEN_COMPLETE:
       if (download_item_ && !download_item_->IsDone())
         return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_OPEN_WHEN_COMPLETE);
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_OPEN);
     case ALWAYS_OPEN_TYPE:
       return l10n_util::GetStringUTF16(GetAlwaysOpenStringId());
     case PLATFORM_OPEN:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_PLATFORM_OPEN);
     case CANCEL:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_CANCEL);
     case TOGGLE_PAUSE:
       if (download_item_ &&
           download_item_->GetState() == DownloadItem::IN_PROGRESS &&
           !download_item_->IsPaused())
         return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_PAUSE_ITEM);
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_RESUME_ITEM);
     case DISCARD:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_DISCARD);
     case KEEP:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_KEEP);
     case LEARN_MORE_SCANNING:
       return l10n_util::GetStringUTF16(IDS_DOWNLOAD_MENU_LEARN_MORE_SCANNING);
     case LEARN_MORE_INTERRUPTED:
       return l10n_util::GetStringUTF16(
           IDS_DOWNLOAD_MENU_LEARN_MORE_INTERRUPTED);
+    default:
+      break;
   }
   NOTREACHED();
   return base::string16();
 }
 
 void DownloadShelfContextMenu::DetachFromDownloadItem() {
   if (!download_item_)
     return;
 
   download_item_->RemoveObserver(this);
@@ skipping 131 matching lines @@
 
 bool DownloadShelfContextMenu::CanOpenPdfInSystemViewer() const {
 #if defined(OS_WIN)
   return IsDownloadPdf() &&
          (IsAdobeReaderDefaultPDFViewer() ? is_adobe_pdf_reader_up_to_date_ :
                                             true);
 #elif defined(OS_MACOSX) || defined(OS_LINUX)
   return IsDownloadPdf();
 #endif
 }