Introduce new compile histogram that includes parsing/caching.

Introduce new compile histogram that includes parsing/caching.

R=vogelheim@chromium.org

Committed: https://crrev.com/6586bd19fd8a9b15e569d0beb3dccb9d4ef95839
Cr-Commit-Position: refs/heads/master@{#26059}

[vogelheim, 2015-01-14 14:37:38]

lgtm.

It should work either way, but please consider the suggestion below.

https://codereview.chromium.org/851953003/diff/1/src/counters.h
File src/counters.h (right):

https://codereview.chromium.org/851953003/diff/1/src/counters.h#newcode318
src/counters.h:318: /* Total compilation time incl. caching/parsing */         \
I was initially surprised at the comment: V8.Compile includes caching/parsing,
too, while the point of this counter is to only show the API-initiated compiles?

Also, super nitpick: CS shows this is will also count the compilation of the
built-ins. That shouldn't happen in any standard Chrome build, though, so I
guess that's not much of a point.

Maybe we can move the counter into api.cc, ScriptCompiler::CompileUnbound. That
shouldn't be used by any internal compiles.

[Yang, 2015-01-14 14:55:21]

https://codereview.chromium.org/851953003/diff/1/src/counters.h
File src/counters.h (right):

https://codereview.chromium.org/851953003/diff/1/src/counters.h#newcode318
src/counters.h:318: /* Total compilation time incl. caching/parsing */         \
On 2015/01/14 14:37:38, vogelheim wrote:
> I was initially surprised at the comment: V8.Compile includes caching/parsing,
> too, while the point of this counter is to only show the API-initiated
compiles?
> 
> Also, super nitpick: CS shows this is will also count the compilation of the
> built-ins. That shouldn't happen in any standard Chrome build, though, so I
> guess that's not much of a point.
> 
> Maybe we can move the counter into api.cc, ScriptCompiler::CompileUnbound.
That
> shouldn't be used by any internal compiles.

As discussed offline, V8.Compile does not include parsing/caching. I'll just
leave the new histogram where they currently are in this CL.

[Yang, 2015-01-14 14:55:35]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-01-14 14:55:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/851953003/1

[commit-bot: I haz the power, 2015-01-14 15:22:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-14 15:23:01]

Patchset 1 (id:??) landed as
https://crrev.com/6586bd19fd8a9b15e569d0beb3dccb9d4ef95839
Cr-Commit-Position: refs/heads/master@{#26059}