LayoutTests/media/track/track-cue-rendering-position-auto.html - Issue 851933003: WebVTT: Support 'auto' text position

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/media/track/track-cue-rendering-position-auto.html

Issue 851933003: WebVTT: Support 'auto' text position (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Updated after some previous CLs. Rebased. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« LayoutTests/media/track/opera/interfaces/VTTCue/position.html ('K') | « LayoutTests/media/track/track-cue-mutable-expected.txt ('k') | LayoutTests/media/track/track-cue-rendering-position-auto-expected.html » ('j') | LayoutTests/media/track/track-cue-rendering-position-auto-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../media-file.js"></script>

	3 <script>

	4 var mediaFile = findMediaFile('video', '../content/test');

	5

	6 function addTrackWithCueData(video, cueData) {

	7 var track = video.addTextTrack('subtitles');

	8 var cue = new VTTCue(0, 10, 'XXX');

	9 for (var prop in cueData)

	10 cue[prop] = cueData[prop];

	11 track.addCue(cue);

	12 track.mode = 'showing';

	13 }

	14 </script>

	15 <style>

	16 video::cue {

	17 font-size: 50px;

	18 color: green;

	19 background-color: green;

	20 }

	21 </style>

	22 <video>

	23 <script>

	24 var video = document.querySelectorAll('video')[0];
	philipj_slow 2015/01/21 15:02:14 Given the structure, document.currentScript.parent Given the structure, document.currentScript.parentNode would work as well. Otherwise there isn't much reason to have the scripts inside the videos AFAICT. fs 2015/01/21 15:28:24 Done. Show quoted text On 2015/01/21 15:02:14, philipj wrote: > Given the structure, document.currentScript.parentNode would work as well. > Otherwise there isn't much reason to have the scripts inside the videos AFAICT. Done.
	25 addTrackWithCueData(video, { align: 'start', line: 0 });

	26 video.src = mediaFile;

	27 </script>

	28 </video>

	29 <video>

	30 <script>

	31 var video = document.querySelectorAll('video')[1];

	32 addTrackWithCueData(video, { align: 'middle', line: 0 });

	33 video.src = mediaFile;

	34 </script>

	35 </video>

	36 <video>

	37 <script>

	38 var video = document.querySelectorAll('video')[2];

	39 addTrackWithCueData(video, { align: 'end', line: 0 });

	40 video.src = mediaFile;

	41 </script>

	42 </video>

OLD	NEW