Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(991)

Issue 851873004: Remove unnecessary dependency on system_wrappers in libjingle. (Closed)

Created:
5 years, 11 months ago by kjellander_chromium
Modified:
5 years, 11 months ago
Reviewers:
perkj_chrome
CC:
chromium-reviews, andresp-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary dependency on system_wrappers in libjingle. The system_wrappers target is already included due to the dependency on the <(DEPTH)/third_party/webrtc/webrtc.gyp:webrtc target. Committed: https://crrev.com/056fa7bf2713b8611bf5cb0069cac5a7989d9b09 Cr-Commit-Position: refs/heads/master@{#311455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/libjingle/libjingle.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
kjellander_chromium
This is causing trouble due to restructuring in https://code.google.com/p/webrtc/source/detail?r=8057
5 years, 11 months ago (2015-01-14 10:34:37 UTC) #2
perkj_chrome
lgtm
5 years, 11 months ago (2015-01-14 10:35:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851873004/1
5 years, 11 months ago (2015-01-14 11:30:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 11:39:01 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 11:40:56 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/056fa7bf2713b8611bf5cb0069cac5a7989d9b09
Cr-Commit-Position: refs/heads/master@{#311455}

Powered by Google App Engine
This is Rietveld 408576698