Issue 851823005: Add unit tests for string_as_array().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 851823005: Add unit tests for string_as_array(). (Closed)

Created:
5 years, 11 months ago by Lei Zhang

Modified:
5 years, 11 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Add unit tests for string_as_array(). Committed: https://crrev.com/b277ef60fae636225837ed5cdaf46e3986a2934f Cr-Commit-Position: refs/heads/master@{#311403}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -0 lines)			Patch
	M	base/stl_util_unittest.cc	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download

Total messages: 7 (2 generated)

Lei Zhang

We grabbed string_as_array() from google3 many years ago, but not the unit tests.

5 years, 11 months ago (2015-01-14 02:32:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851823005/20001

5 years, 11 months ago (2015-01-14 02:47:50 UTC) #5

commit-bot: I haz the power

5 years, 11 months ago (2015-01-14 03:43:06 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/b277ef60fae636225837ed5cdaf46e3986a2934f
Cr-Commit-Position: refs/heads/master@{#311403}