Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 851743004: Add pageset for ugamsolutions.com (Closed)

Created:
5 years, 11 months ago by rmistry
Modified:
5 years, 11 months ago
Reviewers:
*robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 : Initial upload #

Total comments: 2

Patch Set 2 : Fix reason #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
A + tools/skp/page_sets/skia_ugamsolutions_desktop.py View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
rmistry
5 years, 11 months ago (2015-01-13 18:56:47 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/851743004/diff/1/tools/skp/page_sets/skia_ugamsolutions_desktop.py File tools/skp/page_sets/skia_ugamsolutions_desktop.py (right): https://codereview.chromium.org/851743004/diff/1/tools/skp/page_sets/skia_ugamsolutions_desktop.py#newcode35 tools/skp/page_sets/skia_ugamsolutions_desktop.py:35: urls_list = [ I would put the Chrome ...
5 years, 11 months ago (2015-01-13 19:49:56 UTC) #4
rmistry
https://codereview.chromium.org/851743004/diff/1/tools/skp/page_sets/skia_ugamsolutions_desktop.py File tools/skp/page_sets/skia_ugamsolutions_desktop.py (right): https://codereview.chromium.org/851743004/diff/1/tools/skp/page_sets/skia_ugamsolutions_desktop.py#newcode35 tools/skp/page_sets/skia_ugamsolutions_desktop.py:35: urls_list = [ On 2015/01/13 19:49:56, robertphillips wrote: > ...
5 years, 11 months ago (2015-01-13 19:51:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851743004/20001
5 years, 11 months ago (2015-01-13 19:52:21 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 19:52:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/bb928a0c0a4ddc11b05771e9eaa33f1058cc022a

Powered by Google App Engine
This is Rietveld 408576698