Source/platform/heap/Visitor.cpp - Issue 851723002: Oilpan: avoid data race on gcInfo index initialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/Visitor.cpp

Issue 851723002: Oilpan: avoid data race on gcInfo index initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/Visitor.cpp

diff --git a/Source/platform/heap/Visitor.cpp b/Source/platform/heap/Visitor.cpp

index 17ec70ff1da4d8343e6eeb277a33e4b9e743e0d6..b80bf65e7f022d8a28ba2b22cb28317ae1f0ae09 100644

--- a/Source/platform/heap/Visitor.cpp

+++ b/Source/platform/heap/Visitor.cpp

@@ -64,7 +64,7 @@ void GCInfoTable::ensureGCInfoIndex(const GCInfo* gcInfo, size_t* gcInfoIndexSlo

resize();

s_gcInfoTable[gcInfoIndex] = gcInfo;

- *gcInfoIndexSlot = gcInfoIndex;

+ releaseStore(reinterpret_cast<int*>(gcInfoIndexSlot), index);

}

void GCInfoTable::resize()

« no previous file with comments | « Source/platform/heap/Visitor.h ('k') | no next file » | no next file with comments »