Add TestMockTimeTaskRunner in base/test.

Add TestMockTimeTaskRunner in base/test.

Multiple implementations of this functionality exist with slight modifications. This CL consolidates them.

Note: This is a reland of https://codereview.chromium.org/823143004/, which was reverted due to memory leaks, which are now fixed.

BUG=329911
TBR=phajdan.jr@chromium.org,thestig@chromium.org,stevenjb@chromium.org  # Reland.

Committed: https://crrev.com/10b484333c5719b0c1f687fa9ad160dbccb812d4
Cr-Commit-Position: refs/heads/master@{#311343}

[engedy, 2015-01-13 12:49:00]

engedy@chromium.org changed reviewers:
+ bartfab@chromium.org, phajdan.jr@chromium.org, stevenjb@chromium.org,
thestig@chromium.org

[engedy, 2015-01-13 12:50:01]

@Bartosz, I accidentally introduced a cyclic dependency of reference counted
pointers, which is now fixed. PTAL.

[engedy, 2015-01-13 12:52:36]

Patchset #2 (id:10008) has been deleted

[engedy, 2015-01-13 14:21:20]

On 2015/01/13 12:50:01, engedy wrote:
> @Bartosz, I accidentally introduced a cyclic dependency of reference counted
> pointers, which is now fixed. PTAL.

Try bot linux_chromium_chromeos_asan_rel_ng seems to build with asan=1 lsan=1,
and have run the tests successfully now. I have also verified with LSAN enabled
locally.

[stevenjb, 2015-01-13 16:55:42]

rubber-stamp ash/, c/b/chromeos owner lgtm

[engedy, 2015-01-13 17:06:20]

Thanks, Steven!

@Pawel, could you PTAL at the single line change in
test_mock_time_task_runner.h?

[bartfab (slow), 2015-01-13 18:15:46]

https://codereview.chromium.org/851703002/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc
(right):

https://codereview.chromium.org/851703002/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc:63:
base::TestMockTimeTaskRunner* mock_time_task_runner);
You should specify that |mock_time_task_runner| needs to outlive this. Or even
better, use a scoped_refptr since |mock_time_task_runner| is refcounted anyway.

[engedy, 2015-01-13 18:25:56]

https://codereview.chromium.org/851703002/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc
(right):

https://codereview.chromium.org/851703002/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc:63:
base::TestMockTimeTaskRunner* mock_time_task_runner);
On 2015/01/13 18:15:46, bartfab wrote:
> You should specify that |mock_time_task_runner| needs to outlive this. Or even
> better, use a scoped_refptr since |mock_time_task_runner| is refcounted
anyway.

This will be owned by the test-specific class derived from
TestMockTimeTaskRunner, so the self-reference would again be a problem. I have
added a comment.

[bartfab (slow), 2015-01-13 18:29:35]

lgtm

https://codereview.chromium.org/851703002/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc
(right):

https://codereview.chromium.org/851703002/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc:63:
base::TestMockTimeTaskRunner* mock_time_task_runner);
On 2015/01/13 18:25:56, engedy wrote:
> On 2015/01/13 18:15:46, bartfab wrote:
> > You should specify that |mock_time_task_runner| needs to outlive this. Or
even
> > better, use a scoped_refptr since |mock_time_task_runner| is refcounted
> anyway.
> 
> This will be owned by the test-specific class derived from
> TestMockTimeTaskRunner, so the self-reference would again be a problem. I have
> added a comment.

You could make the self-reference not be a problem by destroying the
MockUptimeProvider in TearDown(). But a raw pointer and a comment seem
sufficient to me.

[Lei Zhang, 2015-01-13 19:54:48]

lgtm stamp

[engedy, 2015-01-13 19:59:45]

The CQ bit was checked by engedy@chromium.org

[commit-bot: I haz the power, 2015-01-13 20:00:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/851703002/50001

[commit-bot: I haz the power, 2015-01-13 22:10:15]

Committed patchset #3 (id:50001)

[commit-bot: I haz the power, 2015-01-13 22:11:16]

Patchset 3 (id:??) landed as
https://crrev.com/10b484333c5719b0c1f687fa9ad160dbccb812d4
Cr-Commit-Position: refs/heads/master@{#311343}