Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: Source/core/animation/KeyframeEffectModel.cpp

Issue 851693007: Prepare for responsive CSS animations. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase and tidy up Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/KeyframeEffectModel.cpp
diff --git a/Source/core/animation/KeyframeEffectModel.cpp b/Source/core/animation/KeyframeEffectModel.cpp
index fc1f34f527f23625c0e39c8a4883b41ff85e1b13..dfd23169a597518eca8d1de738b6c9049d5bae2b 100644
--- a/Source/core/animation/KeyframeEffectModel.cpp
+++ b/Source/core/animation/KeyframeEffectModel.cpp
@@ -33,6 +33,10 @@
#include "core/StylePropertyShorthand.h"
#include "core/animation/AnimationNode.h"
+#include "core/animation/CompositorAnimations.h"
+#include "core/animation/css/CSSAnimatableValueFactory.h"
+#include "core/animation/css/CSSPropertyEquality.h"
+#include "core/css/resolver/StyleResolver.h"
#include "platform/animation/AnimationUtilities.h"
#include "platform/geometry/FloatBox.h"
#include "platform/transforms/TransformationMatrix.h"
@@ -60,6 +64,45 @@ void KeyframeEffectModelBase::sample(int iteration, double fraction, double iter
return m_interpolationEffect->getActiveInterpolations(fraction, iterationDuration, result);
}
+void KeyframeEffectModelBase::snapshotCompositableProperties(const Element* element, const LayoutStyle& style)
+{
+ ensureKeyframeGroups();
+ for (CSSPropertyID property : CompositorAnimations::CompositableProperties) {
+ if (affects(property)) {
Timothy Loh 2015/02/11 04:09:00 Maybe reads better as (but no strong preference he
Timothy Loh 2015/02/11 04:16:10 Actually ignore this comment...
+ for (auto& keyframe : m_keyframeGroups->get(property)->m_keyframes) {
+ auto& stringKeyframe = toStringPropertySpecificKeyframe(*keyframe);
+ if (!stringKeyframe.value()) {
+ stringKeyframe.setAnimatableValue(CSSAnimatableValueFactory::create(property, style));
+ } else {
+ ASSERT(!stringKeyframe.getAnimatableValue());
+ stringKeyframe.setAnimatableValue(StyleResolver::createAnimatableValueSnapshot(const_cast<Element&>(*element), property, *stringKeyframe.value()));
+ }
+ }
+ }
+ }
+}
+
+void KeyframeEffectModelBase::updateNeutralKeyframeAnimatableValues(CSSPropertyID property, PassRefPtrWillBeRawPtr<AnimatableValue> value)
+{
+ ASSERT(CompositorAnimations::isCompositableProperty(property));
+
+ if (!value)
+ return;
+
+ ensureKeyframeGroups();
+ auto& keyframes = m_keyframeGroups->get(property)->m_keyframes;
+
+ ASSERT(keyframes.size() >= 2);
+ ASSERT(!toStringPropertySpecificKeyframe(*keyframes[0]).value() || !toStringPropertySpecificKeyframe(*keyframes[keyframes.size() - 1]).value());
Timothy Loh 2015/02/11 04:09:00 Vector supports v.first() and v.last().
shend 2015/02/12 01:01:42 Done.
+
+ if (!toStringPropertySpecificKeyframe(*keyframes[0]).value())
+ toStringPropertySpecificKeyframe(*keyframes[0]).setAnimatableValue(value);
+ if (!toStringPropertySpecificKeyframe(*keyframes[keyframes.size() - 1]).value())
+ toStringPropertySpecificKeyframe(*keyframes[keyframes.size() - 1]).setAnimatableValue(value);
+
+ // FIXME: Handle neutral keyframes that are not at 0% or 100%.
+}
+
KeyframeEffectModelBase::KeyframeVector KeyframeEffectModelBase::normalizedKeyframes(const KeyframeVector& keyframes)
{
double lastOffset = 0;
@@ -125,7 +168,7 @@ void KeyframeEffectModelBase::ensureKeyframeGroups() const
// Add synthetic keyframes.
m_hasSyntheticKeyframes = false;
for (const auto& entry : *m_keyframeGroups) {
- if (entry.value->addSyntheticKeyframeIfRequired())
+ if (entry.value->addSyntheticKeyframeIfRequired(m_neutralKeyframeEasing))
m_hasSyntheticKeyframes = true;
entry.value->removeRedundantKeyframes();
@@ -140,9 +183,7 @@ void KeyframeEffectModelBase::ensureInterpolationEffect(Element* element) const
for (const auto& entry : *m_keyframeGroups) {
const PropertySpecificKeyframeVector& keyframes = entry.value->keyframes();
- ASSERT(keyframes[0]->composite() == AnimationEffect::CompositeReplace);
for (size_t i = 0; i < keyframes.size() - 1; i++) {
- ASSERT(keyframes[i + 1]->composite() == AnimationEffect::CompositeReplace);
double applyFrom = i ? keyframes[i]->offset() : (-std::numeric_limits<double>::infinity());
double applyTo = i == keyframes.size() - 2 ? std::numeric_limits<double>::infinity() : keyframes[i + 1]->offset();
if (applyTo == 1)
@@ -207,18 +248,18 @@ void KeyframeEffectModelBase::PropertySpecificKeyframeGroup::removeRedundantKeyf
ASSERT(m_keyframes.size() >= 2);
}
-bool KeyframeEffectModelBase::PropertySpecificKeyframeGroup::addSyntheticKeyframeIfRequired()
+bool KeyframeEffectModelBase::PropertySpecificKeyframeGroup::addSyntheticKeyframeIfRequired(PassRefPtrWillBeRawPtr<TimingFunction> easing)
{
ASSERT(!m_keyframes.isEmpty());
bool addedSyntheticKeyframe = false;
if (m_keyframes.first()->offset() != 0.0) {
- m_keyframes.insert(0, m_keyframes.first()->neutralKeyframe(0, nullptr));
+ m_keyframes.insert(0, m_keyframes.first()->neutralKeyframe(0, easing));
addedSyntheticKeyframe = true;
}
if (m_keyframes.last()->offset() != 1.0) {
- appendKeyframe(m_keyframes.last()->neutralKeyframe(1, nullptr));
+ appendKeyframe(m_keyframes.last()->neutralKeyframe(1, easing));
addedSyntheticKeyframe = true;
}

Powered by Google App Engine
This is Rietveld 408576698