Prepare for responsive CSS animations.

Source/core/animation/StringKeyframe.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/animation/StringKeyframe.h"
 
 #include "core/animation/ColorStyleInterpolation.h"
 #include "core/animation/ConstantStyleInterpolation.h"
 #include "core/animation/DefaultStyleInterpolation.h"
@@ skipping 19 matching lines @@
 {
 }
 
 void StringKeyframe::setPropertyValue(CSSPropertyID property, const String& value, StyleSheetContents* styleSheetContents)
 {
     ASSERT(property != CSSPropertyInvalid);
     if (CSSAnimations::isAllowedAnimation(property))
         m_propertySet->setProperty(property, value, false, styleSheetContents);
 }
 
+void StringKeyframe::setPropertyValue(CSSPropertyID property, PassRefPtr<CSSValue> value)
+{
+    ASSERT(property != CSSPropertyInvalid);
+    if (CSSAnimations::isAllowedAnimation(property))
+        m_propertySet->setProperty(property, value, false);
+}
+
 PropertySet StringKeyframe::properties() const
 {
     // This is not used in time-critical code, so we probably don't need to
     // worry about caching this result.
     PropertySet properties;
     for (unsigned i = 0; i < m_propertySet->propertyCount(); ++i)
         properties.add(m_propertySet->propertyAt(i).id());
     return properties;
 }
 
@@ skipping 17 matching lines @@
     , m_value(value)
 { }
 
 StringKeyframe::PropertySpecificKeyframe::PropertySpecificKeyframe(double offset, PassRefPtr<TimingFunction> easing, CSSValue* value)
     : Keyframe::PropertySpecificKeyframe(offset, easing, AnimationEffect::CompositeReplace)
     , m_value(value)
 {
     ASSERT(!isNull(m_offset));
 }
 
+void StringKeyframe::PropertySpecificKeyframe::setAnimatableValue(PassRefPtr<AnimatableValue> value)
+{
+    m_animatableValueCache = value;

[Timothy Loh, 2015/02/04 05:31:45]

assert we're a compositable property?

[shend, 2015/02/04 22:51:34]

Oops, PropertySpecificKeyframes don't actually have access to the property.
Instead, I've asserted where this method is called.

+}
+
 // FIXME: Refactor this into a generic piece that lives in InterpolationEffect, and a template parameter specific converter.
 PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::maybeCreateInterpolation(CSSPropertyID property, Keyframe::PropertySpecificKeyframe& end, Element* element) const
 {
     CSSValue* fromCSSValue = m_value.get();
     CSSValue* toCSSValue = toStringPropertySpecificKeyframe(end).value();
     InterpolationRange range = RangeAll;
     bool fallBackToLegacy = false;
 
+    // FIXME: Remove this check once neutral keyframes are implemented in StringKeyframes.
+    if (!fromCSSValue || !toCSSValue)
+        return DeferredLegacyStyleInterpolation::create(fromCSSValue, toCSSValue, property);
+
+    ASSERT(fromCSSValue && toCSSValue);
+
     if (!CSSPropertyMetadata::isAnimatableProperty(property)) {
         // FIXME: Remove this once TimingFunction partitioning is implemented for all types.
         if (!RuntimeEnabledFeatures::webAnimationsAPITimingFunctionPartitioningEnabled())
             return DefaultStyleInterpolation::create(fromCSSValue, toCSSValue, property);
 
         if (fromCSSValue == toCSSValue)
             return ConstantStyleInterpolation::create(fromCSSValue, property);
 
         return nullptr;
     }
@@ skipping 192 matching lines @@
 }
 
 void StringKeyframe::PropertySpecificKeyframe::trace(Visitor* visitor)
 {
     visitor->trace(m_value);
     visitor->trace(m_animatableValueCache);
     Keyframe::PropertySpecificKeyframe::trace(visitor);
 }
 
 }