Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 851693005: [CSS Shapes] Implement BasicShapeInset blending (Closed)

Created:
5 years, 11 months ago by rwlbuis
Modified:
5 years, 11 months ago
Reviewers:
pdr., Zoltan
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-rendering, Dominik Röttsches, dstockwell, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, Mike Lawther (Google), pdr+renderingwatchlist_chromium.org, rjwright, shans, Steve Block, Timothy Loh, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Shapes] Implement BasicShapeInset blending Implement BasicShapeInset blending by blending the inset rect and radius values. This is based on http://trac.webkit.org/changeset/159968 by Zoltan Horvath <zoltan@webkit.org>;. Add tests for -webkit-clip-path and shape-outside using inset. BUG=448295 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188343

Patch Set 1 #

Patch Set 2 : Also add test for -webkit-clip-path #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -4 lines) Patch
M LayoutTests/animations/interpolation/shape-outside.html View 1 chunk +13 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/shape-outside-expected.txt View 2 chunks +12 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-clip-path-interpolation.html View 1 1 chunk +14 lines, -0 lines 0 comments Download
M LayoutTests/animations/interpolation/webkit-clip-path-interpolation-expected.txt View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/rendering/style/BasicShapes.cpp View 1 2 1 chunk +22 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rwlbuis
WDYT?
5 years, 11 months ago (2015-01-13 22:54:49 UTC) #2
Zoltan
Thanks, Rob! lgtm
5 years, 11 months ago (2015-01-13 23:02:17 UTC) #3
rwlbuis
PTAL @pdr
5 years, 11 months ago (2015-01-13 23:03:09 UTC) #5
pdr.
LGTM, thanks!
5 years, 11 months ago (2015-01-13 23:17:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/851693005/40001
5 years, 11 months ago (2015-01-13 23:18:02 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 00:30:49 UTC) #9
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188343

Powered by Google App Engine
This is Rietveld 408576698